Harden ignore ranges by moving them to the lexer/parser#147
Open
JohnathonKoster wants to merge 1 commit intomainfrom
Open
Harden ignore ranges by moving them to the lexer/parser#147JohnathonKoster wants to merge 1 commit intomainfrom
JohnathonKoster wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem
format-ignore-start/format-ignore-endregions were still being modified by the formatter in whitespace-sensitive Blade templates. Spaces before echo tags, blank lines before directives, and even the closing ignore marker itself could be collapsed or merged. The previous behavior also relied too heavily on printer-side reconstruction, which made malformed or nested cases less predictable and made ignore ranges harder to keep idempotent across repeated formatting and wrapper-depth scenarios.The Solution
Moved range-ignore handling to a parser/lexer-backed sentinel flow so ignore regions are treated as opaque slices of original source instead of being rebuilt child-by-child.
IgnoreRangetokens, preserving exact source slices through the matched end marker or EOF.format-ignore/prettier-ignorebehavior unchanged.