Skip to content

fix: nullify bogus wikipedia "Jonny Liette" swimming question - #252

Merged
houtanb merged 1 commit into
forecastingresearch:mainfrom
nikbpetrov:wikipedia-nullify-jonny-liette
Jul 21, 2026
Merged

fix: nullify bogus wikipedia "Jonny Liette" swimming question#252
houtanb merged 1 commit into
forecastingresearch:mainfrom
nikbpetrov:wikipedia-nullify-jonny-liette

Conversation

@nikbpetrov

@nikbpetrov nikbpetrov commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes
    • Corrected handling of questions tied to an invalid or non-existent swimmer record.
    • Such questions now resolve to no result starting from the benchmark period, preventing fabricated information from being returned.

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ea292c9f-3bac-4dae-86a6-c211368a651d

📥 Commits

Reviewing files that changed from the base of the PR and between 169b86e and bd6dff1.

📒 Files selected for processing (1)
  • src/sources/_metadata.py

📝 Walkthrough

Walkthrough

The Wikipedia source metadata now includes a nullification entry for the non-existent swimmer record, effective from the benchmark start date.

Changes

Wikipedia nullification

Layer / File(s) Summary
Add Wikipedia nullification entry
src/sources/_metadata.py
Adds the specified record ID to nullified_questions with BENCHMARK_START_DATE_DATETIME_DATE as its nullification start date.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: nullifying the bogus Wikipedia Jonny Liette swimming question.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

The question asking whether "Jonny Liette" still holds the 50m
backstroke long-course world record is spurious: no such swimmer or
record exists (the men's 50m backstroke WR is held by Kliment
Kolesnikov, 23.55), and the name appears in no revision of the source
article `List_of_world_records_in_swimming`.

Nullify the question from the benchmark start so it is never sampled
and resolves to null in all resolution sets.
@houtanb
houtanb force-pushed the wikipedia-nullify-jonny-liette branch from 169b86e to bd6dff1 Compare July 21, 2026 14:28
@houtanb
houtanb merged commit 87eae2d into forecastingresearch:main Jul 21, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants