Skip to content

Update models, protect nextPolNumber, set nextPolNumber to null only for creation requests#1307

Merged
damien-git merged 3 commits into
masterfrom
MODINVOICE-647
May 15, 2026
Merged

Update models, protect nextPolNumber, set nextPolNumber to null only for creation requests#1307
damien-git merged 3 commits into
masterfrom
MODINVOICE-647

Conversation

@damien-git
Copy link
Copy Markdown
Contributor

@damien-git damien-git commented May 15, 2026

Purpose

MODINVOICE-647 - Invoice line number is reused after deletion

Approach

  • Update models so composite order's nextPolNumber is not read-only
  • Protect nextPolNumber
  • Set nextPolNumber to null only for creation requests

Related PRs


Pre-Review Checklist

  • Self-reviewed Code — Reviewed code for issues, unnecessary parts, and overall quality.
  • Change Notes — NEWS.md updated with clear description and issue key.
  • Testing — Confirmed changes were tested locally or on dev environment.
  • Logging: Confirmed that logging is appropriately handled.
  • Breaking Changes — Handled all required actions if changes affect API, DB, or interface versions.
    • API/schema changes
    • Interface version updates
    • DB schema changes / migration scripts
  • New Properties / Environment Variables — Updated README.md if new configs were added.

@sonarqubecloud
Copy link
Copy Markdown

@damien-git damien-git merged commit 6b3b407 into master May 15, 2026
20 checks passed
@damien-git damien-git deleted the MODINVOICE-647 branch May 15, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants