Skip to content

Conversation

@niko-exo
Copy link

@niko-exo niko-exo commented Dec 30, 2025

ref: https://app.clickup.com/t/86b7gyddp

86b7gyddp - fix: add asterisks

Changelog

  • Add asterisks.

Links

86b7gyddp - Add asterisks to mandatory fields

Evidence

Captura de pantalla de 2025-12-30 17-00-53

Summary by CodeRabbit

  • Style
    • Minor reordering of component property declarations for improved code consistency. No changes to functionality or user-facing behavior.

✏️ Tip: You can customize this high-level summary in your review settings.

<MuiFormikDatepicker
name="expires_at"
label={T.translate(
label={`${T.translate(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niko-exo u already added the is required prop here
04cd07c please reuse that approach

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link

@smarcet smarcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niko-exo please review comments

@niko-exo niko-exo force-pushed the fix/add-asterisks-to-mandatory-fields branch from 5f3c522 to e5edda1 Compare January 19, 2026 17:04
@coderabbitai
Copy link

coderabbitai bot commented Jan 19, 2026

📝 Walkthrough

Walkthrough

A minor prop reordering in a form template component. The required attribute on two date picker fields (opens_at and expires_at) is repositioned to be inline with the name prop, without affecting validation logic or field behavior.

Changes

Cohort / File(s) Summary
Form Template Component
src/pages/sponsors/sponsor-forms-list-page/components/form-template/form-template-form.js
Repositioned required prop inline with name prop on two MuiFormikDatepicker components

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • smarcet

Poem

🐰 Props hop and dance, now in a line,
required finds its spot so fine,
No logic changed, just tidied view—
The form still works, clean and true!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions adding asterisks but the actual change is reordering the 'required' prop on date picker components with no visible behavior change. Update the title to better reflect the actual change, such as 'refactor: reorganize required prop in form template date pickers' or similar.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@smarcet smarcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet smarcet merged commit 85c08aa into master Jan 19, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants