issue-1384: Added sortAreas and removeDuplicateAreas CAP settings#1385
Merged
Conversation
geosaaga
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces two new CAP warning presentation settings intended to improve warning header readability by optionally sorting area names and filtering duplicates (issue #1384).
Changes:
- Extended
CapViewSettingswithsortAreasandremoveDuplicateAreasflags. - Added area-list formatting in
WarningItemto optionally sort and/or deduplicateareasDescription. - Added unit tests covering both sorting and duplicate removal behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/config/types.ts | Adds new optional CAP view settings flags for area sorting/deduplication. |
| src/components/warnings/cap/WarningItem.tsx | Implements optional formatting logic for CAP header area lists based on config. |
| tests/components/WarningItemCap.test.tsx | Adds tests validating the new sorting and deduplication behaviors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to sort area names and remove duplicate area names from warning headers.
Closes #1384