issue-1382: Added geojson and polygon simplification support for CAP warnings#1383
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds GeoJSON rendering for CAP warning areas and optional polygon simplification (meter-based tolerance) to improve map performance and memory usage in the CAP warnings map view.
Changes:
- Introduces
simplifyPolygonutility for simplifying/closing GeoJSON polygon rings using meter tolerance. - Updates CAP warnings
MapViewto render warning areas viareact-native-mapsGeojsoninstead of individualPolygoncomponents. - Adds
capViewSettings.polygonAccuracyconfig option (meters) and updates tests for the new rendering path.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
src/utils/simplifyPolygon.ts |
New utility to simplify GeoJSON polygon rings with meter tolerance. |
src/config/types.ts |
Adds polygonAccuracy?: number to CAP view settings. |
src/components/warnings/cap/MapView.tsx |
Switches CAP area rendering to GeoJSON + optional simplification. |
__tests__/utils/simplifyPolygon.test.ts |
Adds unit coverage for polygon simplification/closure behavior. |
__tests__/components/MapViewCap.test.tsx |
Updates map rendering mock/assertions for GeoJSON rendering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polygon simplification can be configured in
capViewSettings, for examplepolygonAccuracy: 250,Uses 250 meter accuracy, if value is not set then original polygon is used.
Closes #1382