issue-1379: Fix for invalid date bug in CAP warnings#1380
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the CAP warnings header timespan aggregation so that multiple non-overlapping warning intervals no longer produce an “Invalid date” expiry string (issue #1379).
Changes:
- Reworked header timespan interval-building logic to merge overlaps safely and always produce valid onset/expiry pairs.
- Added a regression test ensuring the header does not render “Invalid date” when warnings contain multiple separate time spans.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/components/warnings/cap/WarningBlock.tsx |
Replaces the previous timespan grouping algorithm with a safer interval merge approach to prevent invalid expiry rendering. |
__tests__/components/WarningBlockCap.test.tsx |
Adds a regression test covering multiple separate warning timespans to ensure “Invalid date” is not rendered. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1379