This repository was archived by the owner on Sep 21, 2021. It is now read-only.
WIP Improve testing and refactoring code - #498
Open
rafaelje wants to merge 7 commits into
Open
Conversation
added 5 commits
July 9, 2018 07:42
Signed-off-by: Rafa Hernandez <rhernandez@teclib.com>
Signed-off-by: Rafa Hernandez <rhernandez@teclib.com>
Signed-off-by: Rafa Hernandez <rhernandez@teclib.com>
- implement compile option with java 1.8 - add test powermock library for Base64 static testing - add roboelectric library for Android Context testing Signed-off-by: Rafa Hernandez <rhernandez@teclib.com>
… presenter Signed-off-by: Rafa Hernandez <rhernandez@teclib.com>
rafaelje
changed the title
ajsb85
previously approved these changes
Jul 11, 2018
added 2 commits
July 11, 2018 09:02
Signed-off-by: Rafa Hernandez <rhernandez@teclib.com>
Signed-off-by: Rafa Hernandez <rhernandez@teclib.com>
ajsb85
requested review from
CamposErik and
Ivans51
and removed request for
hectorerb
November 20, 2018 12:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes description
The most important test on this PR is enrollment and deeplink.
The agent has a complete MVP pattern and these tests were created with the instrumented test wish make slow, in this PR I'm moving the model and presenter from instrumented test to unit test with a more clear idea for contributors.
With support for these tools on gradle just available for testing purpose:
Powermock
To mock static class
Robolectric
To create a real Android Context with out instrumented test
Mockito
To create basic mocks
Checklist
Please check if your PR fulfills the following specifications:
Estimated time
References
Closes #N/A
Related #N/A
Depends on #N/A