ddc: deprecate goosefs runtime#5703
ddc: deprecate goosefs runtime#5703TrafalgarZZZ wants to merge 1 commit intofluid-cloudnative:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request deprecates the GooseFS runtime support within the Fluid project. It systematically removes all GooseFS-related code, API definitions, build configurations, Helm charts, and controller logic. This change streamlines the project by eliminating an unsupported or unused runtime, reducing maintenance overhead and simplifying the codebase. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Signed-off-by: TzZtzt <trafalgarz@outlook.com>
aad494e to
35dc4a4
Compare
|
There was a problem hiding this comment.
Code Review
This pull request removes all components related to GooseFS runtime from the Fluid project. This includes deleting the GooseFSRuntime Custom Resource Definition (CRD), its controller, associated Helm charts (fluid-databackup, fluid-dataloader, and the core goosefs chart), Dockerfiles, and all related Go code for API definitions, deepcopy functions, and engine implementations. Additionally, GooseFS-specific entries are removed from build scripts, Makefiles, RBAC roles, and CSI prune configurations. A general improvement was also made to the fuse mount point script logic, introducing SHA256 checks for ConfigMap content to ensure script integrity and facilitate updates.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5703 +/- ##
==========================================
+ Coverage 61.22% 61.39% +0.16%
==========================================
Files 444 440 -4
Lines 30557 30410 -147
==========================================
- Hits 18710 18670 -40
+ Misses 10307 10203 -104
+ Partials 1540 1537 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|



Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
fixes #XXXX
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews