Skip to content

ddc: deprecate goosefs runtime#5703

Draft
TrafalgarZZZ wants to merge 1 commit intofluid-cloudnative:masterfrom
TrafalgarZZZ:deprecated/remove_goosefsengine
Draft

ddc: deprecate goosefs runtime#5703
TrafalgarZZZ wants to merge 1 commit intofluid-cloudnative:masterfrom
TrafalgarZZZ:deprecated/remove_goosefsengine

Conversation

@TrafalgarZZZ
Copy link
Member

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Mar 20, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from trafalgarzzz by writing /assign @trafalgarzzz in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request deprecates the GooseFS runtime support within the Fluid project. It systematically removes all GooseFS-related code, API definitions, build configurations, Helm charts, and controller logic. This change streamlines the project by eliminating an unsupported or unused runtime, reducing maintenance overhead and simplifying the codebase.

Highlights

  • GooseFS Runtime Deprecation: The GooseFS runtime has been entirely deprecated and removed from the project. This includes its API definitions, controller logic, build configurations, and associated Helm charts.
  • Codebase Cleanup: All files and references related to GooseFS, such as its types, OpenAPI definitions, deepcopy functions, and common constants, have been systematically removed across the codebase.
  • Build and Deployment Streamlining: Build scripts (e.g., .github/scripts/build-all-images.sh, Makefile) and Helm charts for data backup and data loading have been updated to remove GooseFS-specific entries, simplifying the build and deployment process.
  • CSI and RBAC Updates: CSI components and Role-Based Access Control (RBAC) configurations have been modified to remove any permissions or references pertaining to the GooseFS runtime.
  • ConfigMap Handling Improvement: The logic for managing ConfigMaps related to mount scripts has been enhanced to use SHA256 hashes for content verification, ensuring that ConfigMaps are only updated when their content actually changes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Signed-off-by: TzZtzt <trafalgarz@outlook.com>
@TrafalgarZZZ TrafalgarZZZ force-pushed the deprecated/remove_goosefsengine branch from aad494e to 35dc4a4 Compare March 20, 2026 06:49
@sonarqubecloud
Copy link

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes all components related to GooseFS runtime from the Fluid project. This includes deleting the GooseFSRuntime Custom Resource Definition (CRD), its controller, associated Helm charts (fluid-databackup, fluid-dataloader, and the core goosefs chart), Dockerfiles, and all related Go code for API definitions, deepcopy functions, and engine implementations. Additionally, GooseFS-specific entries are removed from build scripts, Makefiles, RBAC roles, and CSI prune configurations. A general improvement was also made to the fuse mount point script logic, introducing SHA256 checks for ConfigMap content to ensure script integrity and facilitate updates.

@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 61.39%. Comparing base (50940f8) to head (35dc4a4).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cmd/csi/app/csi.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5703      +/-   ##
==========================================
+ Coverage   61.22%   61.39%   +0.16%     
==========================================
  Files         444      440       -4     
  Lines       30557    30410     -147     
==========================================
- Hits        18710    18670      -40     
+ Misses      10307    10203     -104     
+ Partials     1540     1537       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant