test(dataflowaffinity): migrate to Ginkgo/Gomega#5685
Open
hxrshxz wants to merge 5 commits intofluid-cloudnative:masterfrom
Open
test(dataflowaffinity): migrate to Ginkgo/Gomega#5685hxrshxz wants to merge 5 commits intofluid-cloudnative:masterfrom
hxrshxz wants to merge 5 commits intofluid-cloudnative:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Migrates unit tests in
pkg/controllers/v1alpha1/fluidapp/dataflowaffinity/from the standardtestingpackage to Ginkgo v2/Gomega, adds a package-level suite bootstrap (suite_test.go), and expands test coverage from 39% to 81.4% by adding specs forReconcile,ControllerName,ManagedResource, andNewDataOpJobReconciler.Ⅱ. Does this pull request fix one issue?
#5676
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
ControllerName— asserts the constant string is returnedManagedResource— asserts a*batchv1.Jobis returnedNewDataOpJobReconciler— asserts the constructor wires client correctlyReconcile(4 cases): job not found (propagates error), job with cronjob label (skipped/no-requeue), valid fluid job without affinity annotation (annotation injected), complete job with succeeded pod (node labels injected)injectPodNodeLabelsToJob(2 cases): succeeded pod injects annotations; failed-only pod returns errorⅣ. Describe how to verify it
Ⅴ. Special notes for reviews
N/A