Don't report success when the build is killed by a signal - #68
Open
munzzyy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ufbt_cli()turns theos.system()status into an exit code by shifting off the low byte:The comment is right that the low byte holds the signal number, but that's exactly the case the shift breaks. When the child is killed by a signal the high byte is 0, so
>> 8gives0andufbtexits reporting success for a build that never finished.Ctrl-C during a build is the easy way to hit it. A toolchain segfault or an OOM kill does the same thing. Anything gating on
$?then carries on as if the.fapbuilt, whether that's a wrapper script, a Makefile or CI.os.WIFSIGNALED()andos.WEXITSTATUS()are the documented way to read that status. Using128 + signalmatches what a shell reports, so Ctrl-C shows up as the familiar 130. Normal exits come out unchanged, sinceWEXITSTATUSreturns exactly what the old shift did.Windows is untouched — that branch already skips the shift, and these macros are POSIX-only.