ISSUE-4281: Add ECDH source to static library build#4351
Open
herbenderbler wants to merge 1 commit into
Open
Conversation
MBEDTLS_ECDH_C and mbedtls/ecdh.h are already enabled/exposed, but the ECDH implementation (mbedtls/library/ecdh.c) was not compiled into libmbedtls.a. Add ecdh.c to lib/mbedtls.scons source list so ECDH symbols are available at link/runtime for firmware and apps. Validated with: - ./fbt firmware_all (success) - build log includes CC lib/mbedtls/library/ecdh.c
herbenderbler
marked this pull request as ready for review
March 12, 2026 04:05
turbospok
added
AI-generated
|
Checked this against the actual pinned mbedtls submodule commit rather than just reading the diff: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR enables mbedTLS ECDH at link time by compiling the ECDH implementation into the static library.
MBEDTLS_ECDH_Cand the SDK header are already present, butecdh.cwas not included in the build sources. This resolves ISSUE #4281.What Changed?:
Validation:
./fbt firmware_allsuccessfully.CC lib/mbedtls/library/ecdh.c.