Skip to content

Various UI/UX changes - #4331

Open
xMasterX wants to merge 1 commit into
flipperdevices:devfrom
xMasterX:ui_fixes
Open

Various UI/UX changes#4331
xMasterX wants to merge 1 commit into
flipperdevices:devfrom
xMasterX:ui_fixes

Conversation

@xMasterX

@xMasterX xMasterX commented Jan 21, 2026

Copy link
Copy Markdown
Collaborator

What's new

  • text spacing reduced from 4px to 3px
  • some text was replaced
  • fix nfc slix unlock led not blinking

Verification

  • See text being 3px spaced
  • Try slix unlock menu in nfc

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

text spacing reduced from 4px to 3px
some text was replaced
fix nfc slix unlock led not blinking
@chrisdebian

Copy link
Copy Markdown

Split this into what I could verify: the elements.c/widget_element_text_scroll.c line-spacing change (font_height - 1) is safe — this display's fonts are always well above 1px, so no underflow risk in the size_t arithmetic, and it's applied consistently across all three multiline-text helpers plus the widget scroll leading, not a stray one-off. The SLIX-unlock blink notification addition matches an existing pattern already used identically elsewhere in the NFC app (e.g. nfc_scene_detect.c's nfc_blink_stop/sequence_blink_start_yellow on enter/exit) — it's filling a real scene-symmetry gap rather than introducing new behaviour, though I can't confirm the actual blink timing on-device. Didn't review the two cosmetic string tweaks specifically, low risk either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI Affects UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants