[2.x] fix(sticky): qualify ambiguous id column in is_unread_sticky subquery#4520
Merged
[2.x] fix(sticky): qualify ambiguous id column in is_unread_sticky subquery#4520
id column in is_unread_sticky subquery#4520Conversation
imorland
changed the title
id column in is_unread_sticky subqueryid column in is_unread_sticky subquery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4519.
The correlated subquery that builds the
is_unread_stickycomputed column used a bareidreference:When the outer
discussionsquery is joined by another extension (e.g. byobu addingLEFT JOIN recipients), MySQL raises Column 'id' in where clause is ambiguous. Qualifying it asdiscussions.idresolves this regardless of what JOINs are present.