Skip to content

[fix] resolve {PREFIX} metric init order in module_manager #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ipaqsa merged 2 commits into from
May 5, 2026
+7 −11
Merged

[fix] resolve {PREFIX} metric init order in module_manager #760

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2369fc
resolve {PREFIX} metric name init order
diyliv May 5, 2026
2f80dec
fixed fmt
diyliv May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions pkg/module_manager/module_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,9 @@ import (
)

var (
moduleInfoMetricGroup = "mm_module_info"
moduleInfoMetricName = metrics.ModuleInfoMetricName

moduleInfoMetricGroup = "mm_module_info"
moduleMaintenanceMetricGroup = "mm_module_maintenance"
moduleMaintenanceMetricName = metrics.ModuleMaintenanceMetricName

moduleManagerServiceName = "module-manager"
moduleManagerServiceName = "module-manager"
)

// ModulesState determines which modules should be enabled, disabled or reloaded.
Expand Down Expand Up @@ -294,7 +290,7 @@ func (mm *ModuleManager) validateNewKubeConfig(kubeConfig *config.KubeConfig, al
if moduleConfig.GetMaintenanceState() == utils.NoResourceReconciliation {
mm.dependencies.MetricStorage.Grouped().GaugeSet(
moduleMaintenanceMetricGroup,
moduleMaintenanceMetricName,
metrics.ModuleMaintenanceMetricName,
1,
map[string]string{pkg.MetricKeyModule: moduleName, "state": utils.NoResourceReconciliation.String()},
)
Expand Down Expand Up @@ -507,15 +503,15 @@ func (mm *ModuleManager) SetGlobalDiscoveryAPIVersions(apiVersions []string) {

// UpdateModulesMetrics updates modules' states metrics
func (mm *ModuleManager) UpdateModulesMetrics() {
mm.dependencies.MetricStorage.Grouped().ExpireGroupMetricByName(moduleInfoMetricGroup, moduleInfoMetricName)
mm.dependencies.MetricStorage.Grouped().ExpireGroupMetricByName(moduleInfoMetricGroup, metrics.ModuleInfoMetricName)

for _, module := range mm.GetModuleNames() {
enabled := "false"
if mm.IsModuleEnabled(module) {
enabled = "true"
}

mm.dependencies.MetricStorage.Grouped().GaugeSet(moduleInfoMetricGroup, moduleInfoMetricName, 1, map[string]string{pkg.MetricKeyModule: module, "enabled": enabled})
mm.dependencies.MetricStorage.Grouped().GaugeSet(moduleInfoMetricGroup, metrics.ModuleInfoMetricName, 1, map[string]string{pkg.MetricKeyModule: module, "enabled": enabled})
}
}

Expand All @@ -527,9 +523,9 @@ func (mm *ModuleManager) SetModuleMaintenanceState(moduleName string, state util
slog.String(pkg.LogKeyState, state.String()))

if state == utils.NoResourceReconciliation {
mm.dependencies.MetricStorage.Grouped().GaugeSet(moduleMaintenanceMetricGroup, moduleMaintenanceMetricName, 1, map[string]string{pkg.MetricKeyModule: moduleName, "state": utils.NoResourceReconciliation.String()})
mm.dependencies.MetricStorage.Grouped().GaugeSet(moduleMaintenanceMetricGroup, metrics.ModuleMaintenanceMetricName, 1, map[string]string{pkg.MetricKeyModule: moduleName, "state": utils.NoResourceReconciliation.String()})
} else {
mm.dependencies.MetricStorage.Grouped().ExpireGroupMetricByName(moduleMaintenanceMetricGroup, moduleMaintenanceMetricName)
mm.dependencies.MetricStorage.Grouped().ExpireGroupMetricByName(moduleMaintenanceMetricGroup, metrics.ModuleMaintenanceMetricName)
}
}
}
Expand Down
Loading