Skip to content

feat: return domain with expected challenge values#40

Open
unilynx wants to merge 1 commit into
fishballapp:mainfrom
WebHare:feature/domain-in-challenge
Open

feat: return domain with expected challenge values#40
unilynx wants to merge 1 commit into
fishballapp:mainfrom
WebHare:feature/domain-in-challenge

Conversation

@unilynx

@unilynx unilynx commented Jun 5, 2026

Copy link
Copy Markdown

Challenge handlers need to know which domain name(s) to update for the challenges

@ycmjason

Copy link
Copy Markdown
Member

I understand the use case, but I don’t think domain belongs on DnsTxtRecord/HttpResource. These types represent the resource to provision, and name/url already fully identify that resource. Adding the original authorisation domain mixes ACME metadata into resource descriptions. I’d prefer exposing this separately, e.g. via the challenge/authorisation object, or returning a wrapper object that contains both the resource and the authorisation domain.

Thoughts?

@unilynx

unilynx commented Jun 23, 2026

Copy link
Copy Markdown
Author

I understand the use case, but I don’t think domain belongs on DnsTxtRecord/HttpResource. These types represent the resource to provision, and name/url already fully identify that resource. Adding the original authorisation domain mixes ACME metadata into resource descriptions. I’d prefer exposing this separately, e.g. via the challenge/authorisation object,

There can be multiple domains per challenge/authorization object, correct? We need to know which DNS records should be added to which DNS zone and would like to keep it all together in one challenge

(because dns updates are slow, so we first update all the affected zones and then start waiting until we see the changes propagate before returning back to the ACME client from the challenge)

or returning a wrapper object that contains both the resource and the authorisation domain.

As long as we know which acme-challenge goes into which dns zone, we're happy :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants