SVG fact icons POC

[ekdahl]

This is a proof of concept for adding fact icons as SVGs.
Is it a wanted feature?
How should it preferably be implemented?

Looks like this without theme adjustments:

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 35.37%. Comparing base (fd5af61) to head (8d0635e).

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #5249   +/-   ##
=========================================
  Coverage     35.37%   35.37%           
  Complexity    11196    11196           
=========================================
  Files          1166     1166           
  Lines         48031    48031           
=========================================
  Hits          16990    16990           
  Misses        31041    31041           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[fisharebest]

Is it a wanted feature?

Maybe. We would have to create some styling ideas, and ask the community.

I don't like the icons used by the xenea theme. But I am not a graphic designer, and cannot find a better design...

Note: Previously, I have had comments that the 'cross' icon that is used for death (in the xenea theme) is a christian symbol, and we should either provide config options for jewish/muslim symbols - or find a non-religious symbol.

How should it preferably be implemented?

I have an idea to replace the themes with a "theme editor". Users can choose their prefered colours, fonts, etc.

The existing themes could be just "default settings" for the theme editor.

Custom themes could be replaced by a system to import/export settings, and users could share their themes/settings easily.

I don't know if this is feasible. But it would need a major version change, e.g. webtrees 3.x

[ekdahl]

Is it a wanted feature?

Maybe. We would have to create some styling ideas, and ask the community.

I mean it's already possible to enable/disable it, so it seems logical to supply some default icons in the base application. Maybe it's enough to set some default size/color/alignment fitting each theme.

Note: Previously, I have had comments that the 'cross' icon that is used for death (in the xenea theme) is a christian symbol, and we should either provide config options for jewish/muslim symbols - or find a non-religious symbol.

I actually thought about this, but found it hard to find a neutral icon. The skull or skull-crossbones icons seemed a bit 'morbid' to use, so I just moved on with the cross icon. If there are fitting icons in fontawesome for other religions/beliefs/cultures I guess there can be a setting for default death symbol. Maybe it could be investigated how they're handling it in Geni, MyHeritage, Ancesty, WikiTree etc. to get some ideas.

Maybe it's opening up for endless discussions about what is the most fitting symbol for this or that, but hopefully it's possible to find reasonable symbols that can be agreed on.

How should it preferably be implemented?

I have an idea to replace the themes with a "theme editor". Users can choose their prefered colours, fonts, etc.

The existing themes could be just "default settings" for the theme editor.

Custom themes could be replaced by a system to import/export settings, and users could share their themes/settings easily.

I don't know if this is feasible. But it would need a major version change, e.g. webtrees 3.x

Okay, that sounds like a lot of work and more of a long-term goal.

If we want to supply default icons for facts and events, I'm still curious if this POC is on the right path for the code side of it, rather than discussing what exact icon to use for each GEDCOM tag.

[Norwegian-Sardines]

It would be interesting to have a way to introduce admin / site specific icons, and supply basic ones that can be used or not used by the site admin. If the admin has the money they can purchase their own icons or make their own. This would allow webtrees to find “free to use and distribute” icons (that may be imperfect for everyone), but for a site to purchase their own rights to use icons not supplied or part of webtrees distro but more to their liking!

[RAMINCNZ]

IMHO, the choice of icon could be that of the Admin, with as Fredrik suggests simple EXAMPLE/BASIC icons being used as place holders. Debating Icons could go on forever given the number of WebTrees Users/Installs.

Along with this perhaps an upgrade of the current 'edit' type icons could happen, or even include the option for User Choice??

I'm not much for understanding the coding details for this, however, I would like to see that CSS ids, classes be used in the code where possible to make it easier to 'change' to suit..

A definite PLUS ONE from Me

Rick M
Nu Tirani - New Zealand

[ekdahl]

Updated to place the icon before the title, as the flow is in most UIs.

The one we use now for example:

[fisharebest]

I'm happy with this change in principle. But first,

1. I want to review the list of facts/icons
2. I want to think more about where the facts are defined. This could be in class Fact or in each element.

[ekdahl]

2. I want to think more about where the facts are defined. This could be in class Fact or in each element.

If you have an idea of how and where to have the mapping between tag and icon, I can adjust the PR to follow that.