fix(calm-hub): Adding permission filtering to GET:/namespaces endpoin…#2639
Draft
ConfuddledPenguin wants to merge 1 commit into
Draft
fix(calm-hub): Adding permission filtering to GET:/namespaces endpoin…#2639ConfuddledPenguin wants to merge 1 commit into
ConfuddledPenguin wants to merge 1 commit into
Conversation
|
|
ConfuddledPenguin
force-pushed
the
feature/list-namespace-permissions
branch
2 times, most recently
from
1486b99 to
7324a7f
Compare
Contributor
|
@ConfuddledPenguin this may require minor coordination with #2640 due to that PR introducing |
willosborne
reviewed
Jun 15, 2026
| Set<String> grants = userAccessValidatorInstance.get() | ||
| .getReadableNamespaces(identity.getPrincipal().getName()); | ||
| return new ValueWrapper<>(namespaceStore.getNamespaces().stream() | ||
| .filter(ns -> grants.contains(ns.getName())) |
Member
There was a problem hiding this comment.
Logic makes sense here, but one question: if line 65 already returns the list of readable namespaces for the user, why do we need to retrieve it again from namespaceStore? Can we not just return the readable namespaces directly, saving a query?
finos#2609) Adding in memory filtering of namespaces based on the users permissions following the pattern used in SearchResource.java.
ConfuddledPenguin
force-pushed
the
feature/list-namespace-permissions
branch
from
7324a7f to
e30fc1f
Compare
Member
|
Looks like a few conflicts and a few things to updated. Thanks @ConfuddledPenguin for the work so far |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t (#2609)
Adding in memory filtering of namespaces based on the users permissions following the pattern used in SearchResource.java
Description
Updating the existing
GET:/namespacesendpoint so that the returned namespaces are filtered based on a users permissions. This is done in memory, rather than at the DB level, following the pattern insrc/main/java/org/finos/calm/resources/SearchResource.java.Type of Change
Affected Components
cli/)calm/)calm-ai/)calm-hub/)calm-hub-ui/)calm-server/)calm-widgets/)docs/)shared/)calm-plugins/vscode/)Commit Message Format ✅
Testing
Checklist