http: extract url module, add redirect support, and fix host header#50
Conversation
findstr
commented
May 4, 2026
findstr
commented
- Extract URL parsing/encoding from helper into net.http.url module
- Implement HTTP redirect following (301/302/303/307/308) with loop detection
- Add client.close() to gracefully shut down pooled connections
- Fix host header duplication: h1/h2 now inject Host/:authority from URL authority without modifying the user's header table
- Add tests for host header deduplication in h1 and h2
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 74555db0d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
findstr
force-pushed
the
http/client
branch
4 times, most recently
from
22a57ae to
b53b636
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b53b636735
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Extract URL parsing/encoding from helper into net.http.url module - Implement HTTP redirect following (301/302/303/307/308) with loop detection - Add client.close() to gracefully shut down pooled connections - Fix host header duplication: h1/h2 now inject Host/:authority from URL authority without modifying the user's header table - Add tests for host header deduplication in h1 and h2 - read/readall now use a single deadline timer instead of per-read timeouts, eliminating timeout amplification for chunked/content-length responses.
1 participant
