Fix: Fixed an issue where archives with reserved item names wouldn't extract correctly #18070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lamparter
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where "." and ".." directory entries in archives were being incorrectly treated as meaningful top-level items during smart extraction. The fix ensures that when using "Extract (smart)" on archives containing "." (current directory) or ".." (parent directory) entries, these special directory references are properly ignored when determining whether to create a subfolder.
Changes:
- Refactored the logic for detecting multiple top-level items in archives to filter out "." and ".." entries
- Introduced a new helper function
GetFirstMeaningfulSegmentthat skips special directory references when parsing archive entry paths
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/Files.App/Actions/Content/Archives/Decompress/BaseDecompressArchiveAction.cs
Outdated
Show resolved
Hide resolved
Lamparter
force-pushed
the
protected-names-extraction
branch
from
a182e47 to
b10666d
Compare
(just a general readability refactor, no impact made)
Contributor
Author
|
@yaira2 requesting your review |
Member
|
Noted. I'd like to complete your earlier PRs before reviewing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Steps used to test these changes
tar --exclude=archive.tar -cf archive.tar .in Powershell