-
-
Notifications
You must be signed in to change notification settings - Fork 89
Add --tunnel-service option to lookup, inbox, and relay commands #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This provides a consistent way to select the tunneling service (localhost.run, serveo.net, or pinggy.io) across all CLI commands that use tunneling. Also adds --tunnel-service as an alias to the existing -s/--service option in the tunnel command. The option is only available when tunneling is enabled, using Optique's or() combinator for mutually exclusive option groups. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary of ChangesHello @sij411, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request successfully introduces the --tunnel-service option across the lookup, inbox, and relay commands, and adds it as an alias to the tunnel command. The implementation correctly uses Optique's or() combinator to ensure --tunnel-service is only available when tunneling is enabled, providing a clean and mutually exclusive option handling. The changes are consistent across affected files and integrate well with the existing spawnTemporaryServer utility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a --tunnel-service option to the lookup, inbox, and relay commands, allowing users to select a specific tunneling service. It also adds --tunnel-service as an alias for the tunnel command for consistency. The implementation correctly uses optique's or combinator to ensure that --tunnel-service is mutually exclusive with --no-tunnel, which is a nice improvement.
The changes are well-implemented and consistent across the different commands. I have one suggestion to improve maintainability by refactoring the duplicated tunnelService option definition into a shared constant. This would also be a good opportunity to ensure consistency in the CLI help messages.
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Extract duplicated tunnel service option definitions into a new options.ts module: - TUNNEL_SERVICES constant for the list of available services - tunnelServiceOption for commands where tunneling is implicit - tunnelOption for commands with optional tunneling (--no-tunnel) Use valueSet() for consistent description formatting across all commands. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully introduces the --tunnel-service option across lookup, inbox, and relay commands, and establishes it as an alias for the existing -s/--service in the tunnel command. The refactoring of tunneling options into a dedicated options.ts file, leveraging Optique's or() combinator, significantly enhances code reusability and consistency. The changes are well-implemented and align with the stated objectives, improving the flexibility and user experience of the CLI tools.
Extract duplicated tunnel service option definitions into a new options.ts module: - TUNNEL_SERVICES constant for the list of available services - tunnelServiceOption for commands where tunneling is implicit - tunnelOption for commands with optional tunneling (--no-tunnel) Use valueSet() for consistent description formatting across all commands. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…into feat/tunnel-service
dahlia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to document these new options in docs/cli.md.
Oh yes, got it. |
Add documentation for the new --tunnel-service option: - fedify lookup: for use with -a/--authorized-fetch - fedify inbox: for specifying tunneling service - fedify tunnel: add --tunnel-service as alias to -s/--service 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
dahlia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks as always. Great work!
Summary
--tunnel-serviceoption tofedify lookup,fedify inbox, andfedify relaycommands to select the tunneling service (localhost.run, serveo.net, or pinggy.io)--tunnel-serviceas an alias to the existing-s/--serviceoption in thefedify tunnelcommand for consistencyor()combinator to make--tunnel-serviceonly available when tunneling is enabled (mutually exclusive with--no-tunnel)Closes #525
Test plan
fedify lookup --helpand verify--tunnel-serviceoption appearsfedify inbox --helpand verify--tunnel-serviceoption appearsfedify relay --helpand verify--tunnel-serviceoption appearsfedify tunnel --helpand verify--tunnel-servicealias worksfedify lookup -a --tunnel-service serveo.net acct:hongminhee@hollo.socialto verify the option works--tunnel-servicecannot be used together with--no-tunnel🤖 Generated with Claude Code