Skip to content

fix: add path traversal guard in sync_marketplace_to_plugins.py #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xiaolai wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: add path traversal guard in sync_marketplace_to_plugins.py #170

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d94a038
fix: add path traversal guard in sync_marketplace_to_plugins.py
claude[bot] Apr 22, 2026
0cc2f27
Merge branch 'main' into fix/nlpm-path-traversal-guard
fcakyon Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions plugins/claude-tools/hooks/scripts/sync_marketplace_to_plugins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ def sync_marketplace_to_plugins():

# Resolve plugin directory relative to marketplace root
plugin_dir = (marketplace_dir / source).resolve()
# Guard against path traversal if marketplace.json is tampered
if not str(plugin_dir).startswith(str(marketplace_dir.resolve())):
print(f"⚠ Skipping {source!r}: resolved path escapes plugin root", file=sys.stderr)
continue
plugin_json_dir = plugin_dir / ".claude-plugin"
plugin_json_path = plugin_json_dir / "plugin.json"

Expand Down
Loading