chore: remove dead SubscriptionRef layer and unused helpers#52
Merged
Conversation
Deletes an Effect SubscriptionRef/Stream mirror on four pub/sub stores that had zero production consumers (only a test file read the streams), plus dead helper clusters in bulk-edit/bulk-duplicate/bulk-actions utils and a handful of standalone unused symbols. All stores keep their live callback subscribe() API; getSelectionSnapshot is preserved since selection-control.tsx depends on it. Verified via grep (0 references to every removed symbol), typecheck, full test suite, and production build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Test plan
Summary by cubic
Removed unused
effectSubscriptionRef/Stream layers from queue, selection, toast, and checkbox-portal stores, plus dead helpers/types/icons across bulk-edit/duplicate/actions and lib. No behavior change; stores keep the callback subscribe() API, and the selection snapshot accessor remains.queueStore,selectionStore,toastStore, andcheckboxPortalStore; kept the synchronous selection snapshot accessor.src/lib/store-streams.test.ts.SEARCH_OWNER_REPOS,sprintProgress,SecondaryAction,CircleCheckIcon,UnpinIcon,disposeRuntime,DistributionFunction,BulkFlyoutMode,MessageKey).Written for commit c0831bc. Summary will update on new commits.