Skip to content

chore: remove dead SubscriptionRef layer and unused helpers#52

Merged
fathiraz merged 2 commits into
mainfrom
chore/remove-dead-code-audit
Jul 18, 2026
Merged

chore: remove dead SubscriptionRef layer and unused helpers#52
fathiraz merged 2 commits into
mainfrom
chore/remove-dead-code-audit

Conversation

@fathiraz

@fathiraz fathiraz commented Jul 18, 2026

Copy link
Copy Markdown
Owner

Summary

  • Removes an Effect SubscriptionRef/Stream mirror bolted onto four pub/sub stores (queue, checkbox-portal, toast, selection) that had zero production consumers — the app uses each store's plain callback subscribe() API. getSelectionSnapshot is kept (used by selection-control.tsx).
  • Deletes src/lib/store-streams.test.ts, which only tested the removed selectionChanges/toastChanges streams.
  • Removes dead helper clusters in bulk-edit-utils.tsx, bulk-duplicate-utils.tsx, and bulk-actions-utils.tsx, plus a handful of standalone unused exports (SEARCH_OWNER_REPOS, sprintProgress, SecondaryAction, CircleCheckIcon, UnpinIcon, disposeRuntime, resetHovercardAppendTargetForTests, DistributionFunction, BulkFlyoutMode, MessageKey).
  • Net: 17 files changed, +5/-379 lines. No behavior change — every removed symbol had zero cross-file references.

Test plan

  • pnpm typecheck — no errors
  • pnpm test — 42 files / 419 tests pass
  • pnpm build — production build succeeds
  • Grepped each of the 34 removed symbols — 0 references remain

Summary by cubic

Removed unused effect SubscriptionRef/Stream layers from queue, selection, toast, and checkbox-portal stores, plus dead helpers/types/icons across bulk-edit/duplicate/actions and lib. No behavior change; stores keep the callback subscribe() API, and the selection snapshot accessor remains.

  • Refactors
    • Removed stream mirrors from queueStore, selectionStore, toastStore, and checkboxPortalStore; kept the synchronous selection snapshot accessor.
    • Deleted src/lib/store-streams.test.ts.
    • Removed unused helpers/exports (examples: SEARCH_OWNER_REPOS, sprintProgress, SecondaryAction, CircleCheckIcon, UnpinIcon, disposeRuntime, DistributionFunction, BulkFlyoutMode, MessageKey).
    • Net: +5 / -379 across 17 files.

Written for commit c0831bc. Summary will update on new commits.

Review in cubic

Deletes an Effect SubscriptionRef/Stream mirror on four pub/sub stores
that had zero production consumers (only a test file read the streams),
plus dead helper clusters in bulk-edit/bulk-duplicate/bulk-actions utils
and a handful of standalone unused symbols. All stores keep their live
callback subscribe() API; getSelectionSnapshot is preserved since
selection-control.tsx depends on it.

Verified via grep (0 references to every removed symbol), typecheck,
full test suite, and production build.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor auto review

No actionable issues found on changed lines.

No actionable issues found.

Generated automatically when this PR was submitted using Cursor CLI with --model auto.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 17 files

Re-trigger cubic

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: low. Cursor Bugbot was not configured on this PR; cubic and Cursor auto review reported no issues. Approved — dead-code removal with no behavior change and limited blast radius.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Approver

@fathiraz
fathiraz merged commit 15e4b5f into main Jul 18, 2026
5 checks passed
@fathiraz
fathiraz deleted the chore/remove-dead-code-audit branch July 18, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant