[PVM] Enhance djump & branch pc handling and check post pc & gas in PVM tests#150
Merged
[PVM] Enhance djump & branch pc handling and check post pc & gas in PVM tests#150
djump & branch pc handling and check post pc & gas in PVM tests#150Conversation
0xjunha
added a commit
that referenced
this pull request
Jun 17, 2025
…in PVM tests (#150) * Update pc & gas counter values on page-fault * Update `djump` & `branch`: pc progress conditions * Test pc values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
djumpandbranchinstructions to return correct posterior pc valuesΨto pass test vectors:PageFaultsets pc to zero (whereas in GP it doesn't)Panic&Haltdoesn't set pc to zero (in GP it does)TRAPdoesn't progress pc values