Fix: Support iteration and indexing for ModelSimple list responses#109
Open
Xyerophyte wants to merge 2 commits intofastly:mainfrom
Open
Fix: Support iteration and indexing for ModelSimple list responses#109Xyerophyte wants to merge 2 commits intofastly:mainfrom
Xyerophyte wants to merge 2 commits intofastly:mainfrom
Conversation
- Add __iter__, __len__, and enhanced __getitem__ to ModelSimple - Fixes ApiAttributeError when iterating DomainsResponse and similar models - Users can now use for loops, list comprehensions, indexing, and len() - Add comprehensive test coverage in test_model_simple_sequence.py - Update CHANGELOG.md for v12.0.0 Fixes issue where DomainsResponse._data_store had to be accessed directly to iterate over domain lists. Now DomainsResponse and other ModelSimple list-based responses behave like native Python sequences.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
DomainsResponseclass (and otherModelSimple-based list response models) could not be iterated, causingApiAttributeErrorwhen attempting common operations:Users had to access the internal
_data_storedirectly, breaking the abstraction.Root Cause
DomainsResponseinherits fromModelSimpleand stores a list in itsvalueattribute. When Python's iteration protocol calls__getitem__(0), the existing implementation only accepted string attribute names, not integer indices.Solution
Enhanced the
ModelSimpleclass infastly/model_utils.pywith sequence protocol support:__getitem__- Now accepts integers and slices, delegating to the underlyingvaluelist/tuple__iter__- Returns an iterator over the sequence invalue__len__- Returns the length of the sequence invalueThe implementation intelligently handles:
What Now Works
Testing
tests/test_model_simple_sequence.pyDocumentation
CHANGELOG.md(v12.0.0 bug fixes section)Impact
ModelSimpleinstances that wrap sequences