Additional colours with cyclic usage#2
Conversation
Super trouper security user job scripts displaying
|
Thanks for the patches! I hesitated when I saw this because of the additional PIL imports that I'd like to avoid requiring by default, but now I see this is a different issue: There are commits here for both the cyclic color picking and removing the JobScript/JobScriptPreview text from the report, replacing it with an image. Is that intentional? If so, could you or @fafik23 explain what's gained and/or lossed (i.e. hidden) with the text-to-image code? Even if it was included unintentionally, maybe it's something good for the mainline. Best if you could separate the color-picking and text-to-image issues into branches that can be dealt with independently, though I see now this is almost all the latter. Actually, the text-to-image patches deal with lines that have since changed. Since it's taken me a while to deal with this pull request, I can help with the merging once I understand what the goal is. Thanks! |
|
Cyclic colours are in two first patches only - they deal only with one file. text-to-image conversion was done by @fafik23 because we considered a security risk that someone can introduce for example a malicoius java script code into job script so it will be executed on administrators work station (we now it's a bit funny). |
|
Cool, I'll merge in the color code , and I've created issue #7 to make sure code injection is confidently prevented one way or another. Thanks for the insight! |
|
I've added the extra colors. Patch ed849a2 in this pull request (which deals with the possible Thanks! |
Very simple but maybe will help someone trying to monitor more partitions than predefined colours in array.