allow more options to be defined on datasets, mainly bar and color #35
Open
ThomasBrodt wants to merge 44 commits into
Open
allow more options to be defined on datasets, mainly bar and color #35ThomasBrodt wants to merge 44 commits into
ThomasBrodt wants to merge 44 commits into
Conversation
Owner
|
Thanks for the PR. The 3.0 branch was not complete and targeted on old beta version ChartJS. Upstream changed how plugins works(i.e. remove babel on compile), so more fix should be done to make it working on 3.0. |
|
I did a version that works with Chart.js 3, but it is far from ready to make a PR, it is pretty breaking and was tailored for our own use case. Will try to make a PR out of it. |
Owner
|
Another thing, this plugin should use date adapter instead of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made some changes to the 0.4.0 version of the timeline plugin, based on requirements we would like to implement with the timeline plugin. I would like to know what you think about that.
We are currently still on chartJs version 2.9.4 and this would be the required version for the modifications, too. (BTW, you've also started a branch for the 3.x version, is this already finished?)
This would require a version bump, because it may also breaks some existing use cases, mainly the use of colorFunction.
It would offer some new features, though, a new demo file dataset-colors.html shows some examples: