Switch in-repo formatting to simple local gradle task#628
Open
ZacSweers wants to merge 6 commits into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
Author
|
the codeql failure seems like a CI issue? |
Contributor
|
Yeah, I need to fix this codeql thing, don't worry about it. Great set of changes here. I sent you some comments on slack about it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous setup of using the ktfmt Gradle plugin but backdooring in the local ktfmt was finicky and resulting periodic stale runs and prone to ABI breakages. This switches the repo to just run a simple local JavaExec that consumes the compiler artifact directly. This way it's always aligned and doesn't get dinged by Gradle hacks.
Running this also caught and fixed a number of formatting issues on
main!