Skip to content

minipack3ba: platform: Support second source of SMB and 3V3#782

Closed
brandonchuang wants to merge 1 commit intofacebook:mainfrom
brandonchuang:mp3ba_smb_3v3_2nd
Closed

minipack3ba: platform: Support second source of SMB and 3V3#782
brandonchuang wants to merge 1 commit intofacebook:mainfrom
brandonchuang:mp3ba_smb_3v3_2nd

Conversation

@brandonchuang
Copy link
Copy Markdown
Contributor

@brandonchuang brandonchuang commented Jan 7, 2026

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run
image

Summary:

This PR adds support for the second source of SMB, 3V3_L, and 3V3_R.

  1. Add versionedPmUnitConfigs of SMB and 3V3 slot in platform_manager.json
  2. Add versionedSensors in sensor service.json
  3. Supported the following versions for SMB and 3V3:
    2.1.0
    3.1.0
    4.1.0
    4.1.10 (second source)
    4.1.20

Test Plan:

  1. Compilation and configuration validation completed successfully.
  2. On minipack3ba devices equipped with each SMB/3V3 versions:
    • platform_manager start and run normally.
    • sensor_service start and run normally.
      Resolved to versionedPmSensors config with version 4.1.20 for pmUnit SMB at /SMB_SLOT@0
      Resolved to versionedPmSensors config with version 4.1.20 for pmUnit 3V3_L at /SMB_SLOT@0/OPTICL_SLOT@0
      Resolved to versionedPmSensors config with version 4.1.20 for pmUnit 3V3_R at /SMB_SLOT@0/OPTICR_SLOT@0
      Resolved to versionedPmSensors config with version 4.1.10 for pmUnit SMB at /SMB_SLOT@0
      Resolved to versionedPmSensors config with version 4.1.10 for pmUnit 3V3_L at /SMB_SLOT@0/OPTICL_SLOT@0
      Resolved to versionedPmSensors config with version 4.1.10 for pmUnit 3V3_R at /SMB_SLOT@0/OPTICR_SLOT@0
      Resolved to versionedPmSensors config with version 4.1.0 for pmUnit SMB at /SMB_SLOT@0
      Resolved to versionedPmSensors config with version 4.1.0 for pmUnit 3V3_L at /SMB_SLOT@0/OPTICL_SLOT@0
      Resolved to versionedPmSensors config with version 4.1.0 for pmUnit 3V3_R at /SMB_SLOT@0/OPTICR_SLOT@0
      Resolved to versionedPmSensors config with version 3.1.0 for pmUnit SMB at /SMB_SLOT@0
      Resolved to versionedPmSensors config with version 3.1.0 for pmUnit 3V3_L at /SMB_SLOT@0/OPTICL_SLOT@0
      Resolved to versionedPmSensors config with version 3.1.0 for pmUnit 3V3_R at /SMB_SLOT@0/OPTICR_SLOT@0
      Resolved to versionedPmSensors config with version 2.1.0 for pmUnit SMB at /SMB_SLOT@0
      Resolved to versionedPmSensors config with version 2.1.0 for pmUnit 3V3_L at /SMB_SLOT@0/OPTICL_SLOT@0
      Resolved to versionedPmSensors config with version 2.1.0 for pmUnit 3V3_R at /SMB_SLOT@0/OPTICR_SLOT@0
    • All sensors are correctly discovered, sensor_service_client all test cases passed.
    • Executed platform_manager_hw_test and sensor_service_hw_test; all test cases passed.

Please refer the full logs:
mp3ba_smb_3v3_2nd_source_log.zip

Summary:
  This PR adds support for the second source of SMB, 3V3_L, and 3V3_R.
  1. Add `versionedPmUnitConfigs` of SMB and 3V3 slot in platform_manager.json
  2. Add `versionedSensors` in sensor service.json
  3. Supported the following versions for SMB and 3V3:
     2.1.0
     3.1.0
     4.1.0
     4.1.10 (second source)
     4.1.20

Test Plan:
  1. Compilation and configuration validation completed successfully.
  2. On minipack3ba devices equipped with each SMB/3V3 versions:
     - platform_manager start and run normally.
     - sensor_service start and run normally.
       Resolved to versionedPmSensors config with version 4.1.20 for pmUnit SMB at /SMB_SLOT@0
       Resolved to versionedPmSensors config with version 4.1.20 for pmUnit 3V3_L at /SMB_SLOT@0/OPTICL_SLOT@0
       Resolved to versionedPmSensors config with version 4.1.20 for pmUnit 3V3_R at /SMB_SLOT@0/OPTICR_SLOT@0
       Resolved to versionedPmSensors config with version 4.1.10 for pmUnit SMB at /SMB_SLOT@0
       Resolved to versionedPmSensors config with version 4.1.10 for pmUnit 3V3_L at /SMB_SLOT@0/OPTICL_SLOT@0
       Resolved to versionedPmSensors config with version 4.1.10 for pmUnit 3V3_R at /SMB_SLOT@0/OPTICR_SLOT@0
       Resolved to versionedPmSensors config with version 4.1.0 for pmUnit SMB at /SMB_SLOT@0
       Resolved to versionedPmSensors config with version 4.1.0 for pmUnit 3V3_L at /SMB_SLOT@0/OPTICL_SLOT@0
       Resolved to versionedPmSensors config with version 4.1.0 for pmUnit 3V3_R at /SMB_SLOT@0/OPTICR_SLOT@0
       Resolved to versionedPmSensors config with version 3.1.0 for pmUnit SMB at /SMB_SLOT@0
       Resolved to versionedPmSensors config with version 3.1.0 for pmUnit 3V3_L at /SMB_SLOT@0/OPTICL_SLOT@0
       Resolved to versionedPmSensors config with version 3.1.0 for pmUnit 3V3_R at /SMB_SLOT@0/OPTICR_SLOT@0
       Resolved to versionedPmSensors config with version 2.1.0 for pmUnit SMB at /SMB_SLOT@0
       Resolved to versionedPmSensors config with version 2.1.0 for pmUnit 3V3_L at /SMB_SLOT@0/OPTICL_SLOT@0
       Resolved to versionedPmSensors config with version 2.1.0 for pmUnit 3V3_R at /SMB_SLOT@0/OPTICR_SLOT@0
     - All sensors are correctly discovered, sensor_service_client all test cases passed.
     - Executed platform_manager_hw_test and sensor_service_hw_test; all test cases passed.

Please refer the full logs:
[mp3ba_smb_3v3_2nd_source_log.zip](https://github.com/user-attachments/files/24467348/mp3ba_smb_3v3_2nd_source_log.zip)
@meta-cla meta-cla Bot added the CLA Signed label Jan 7, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Jan 8, 2026

@tao-ren has imported this pull request. If you are a Meta employee, you can view this in D90296508.

@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Jan 24, 2026

@tao-ren merged this pull request in aecbcb1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants