minipack3ba: platform: Support second source of SMB and 3V3#782
Closed
brandonchuang wants to merge 1 commit intofacebook:mainfrom
Closed
minipack3ba: platform: Support second source of SMB and 3V3#782brandonchuang wants to merge 1 commit intofacebook:mainfrom
brandonchuang wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary:
This PR adds support for the second source of SMB, 3V3_L, and 3V3_R.
1. Add `versionedPmUnitConfigs` of SMB and 3V3 slot in platform_manager.json
2. Add `versionedSensors` in sensor service.json
3. Supported the following versions for SMB and 3V3:
2.1.0
3.1.0
4.1.0
4.1.10 (second source)
4.1.20
Test Plan:
1. Compilation and configuration validation completed successfully.
2. On minipack3ba devices equipped with each SMB/3V3 versions:
- platform_manager start and run normally.
- sensor_service start and run normally.
Resolved to versionedPmSensors config with version 4.1.20 for pmUnit SMB at /SMB_SLOT@0
Resolved to versionedPmSensors config with version 4.1.20 for pmUnit 3V3_L at /SMB_SLOT@0/OPTICL_SLOT@0
Resolved to versionedPmSensors config with version 4.1.20 for pmUnit 3V3_R at /SMB_SLOT@0/OPTICR_SLOT@0
Resolved to versionedPmSensors config with version 4.1.10 for pmUnit SMB at /SMB_SLOT@0
Resolved to versionedPmSensors config with version 4.1.10 for pmUnit 3V3_L at /SMB_SLOT@0/OPTICL_SLOT@0
Resolved to versionedPmSensors config with version 4.1.10 for pmUnit 3V3_R at /SMB_SLOT@0/OPTICR_SLOT@0
Resolved to versionedPmSensors config with version 4.1.0 for pmUnit SMB at /SMB_SLOT@0
Resolved to versionedPmSensors config with version 4.1.0 for pmUnit 3V3_L at /SMB_SLOT@0/OPTICL_SLOT@0
Resolved to versionedPmSensors config with version 4.1.0 for pmUnit 3V3_R at /SMB_SLOT@0/OPTICR_SLOT@0
Resolved to versionedPmSensors config with version 3.1.0 for pmUnit SMB at /SMB_SLOT@0
Resolved to versionedPmSensors config with version 3.1.0 for pmUnit 3V3_L at /SMB_SLOT@0/OPTICL_SLOT@0
Resolved to versionedPmSensors config with version 3.1.0 for pmUnit 3V3_R at /SMB_SLOT@0/OPTICR_SLOT@0
Resolved to versionedPmSensors config with version 2.1.0 for pmUnit SMB at /SMB_SLOT@0
Resolved to versionedPmSensors config with version 2.1.0 for pmUnit 3V3_L at /SMB_SLOT@0/OPTICL_SLOT@0
Resolved to versionedPmSensors config with version 2.1.0 for pmUnit 3V3_R at /SMB_SLOT@0/OPTICR_SLOT@0
- All sensors are correctly discovered, sensor_service_client all test cases passed.
- Executed platform_manager_hw_test and sensor_service_hw_test; all test cases passed.
Please refer the full logs:
[mp3ba_smb_3v3_2nd_source_log.zip](https://github.com/user-attachments/files/24467348/mp3ba_smb_3v3_2nd_source_log.zip)
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary:
This PR adds support for the second source of SMB, 3V3_L, and 3V3_R.
versionedPmUnitConfigsof SMB and 3V3 slot in platform_manager.jsonversionedSensorsin sensor service.json2.1.0
3.1.0
4.1.0
4.1.10 (second source)
4.1.20
Test Plan:
Resolved to versionedPmSensors config with version 4.1.20 for pmUnit SMB at /SMB_SLOT@0
Resolved to versionedPmSensors config with version 4.1.20 for pmUnit 3V3_L at /SMB_SLOT@0/OPTICL_SLOT@0
Resolved to versionedPmSensors config with version 4.1.20 for pmUnit 3V3_R at /SMB_SLOT@0/OPTICR_SLOT@0
Resolved to versionedPmSensors config with version 4.1.10 for pmUnit SMB at /SMB_SLOT@0
Resolved to versionedPmSensors config with version 4.1.10 for pmUnit 3V3_L at /SMB_SLOT@0/OPTICL_SLOT@0
Resolved to versionedPmSensors config with version 4.1.10 for pmUnit 3V3_R at /SMB_SLOT@0/OPTICR_SLOT@0
Resolved to versionedPmSensors config with version 4.1.0 for pmUnit SMB at /SMB_SLOT@0
Resolved to versionedPmSensors config with version 4.1.0 for pmUnit 3V3_L at /SMB_SLOT@0/OPTICL_SLOT@0
Resolved to versionedPmSensors config with version 4.1.0 for pmUnit 3V3_R at /SMB_SLOT@0/OPTICR_SLOT@0
Resolved to versionedPmSensors config with version 3.1.0 for pmUnit SMB at /SMB_SLOT@0
Resolved to versionedPmSensors config with version 3.1.0 for pmUnit 3V3_L at /SMB_SLOT@0/OPTICL_SLOT@0
Resolved to versionedPmSensors config with version 3.1.0 for pmUnit 3V3_R at /SMB_SLOT@0/OPTICR_SLOT@0
Resolved to versionedPmSensors config with version 2.1.0 for pmUnit SMB at /SMB_SLOT@0
Resolved to versionedPmSensors config with version 2.1.0 for pmUnit 3V3_L at /SMB_SLOT@0/OPTICL_SLOT@0
Resolved to versionedPmSensors config with version 2.1.0 for pmUnit 3V3_R at /SMB_SLOT@0/OPTICR_SLOT@0
Please refer the full logs:
mp3ba_smb_3v3_2nd_source_log.zip