Replace deprecated torchx Runner.stop() with cancel() #4818
+34
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4818 +/- ##
=======================================
Coverage 96.71% 96.71%
=======================================
Files 586 586
Lines 61307 61308 +1
=======================================
+ Hits 59296 59297 +1
Misses 2011 2011 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary: Using `test` for non-test objects raises warnings from Pytest, this diff renames test classes to mock classes, and puts a flag on testofnoeffect to allow it to not trigger the warning Reviewed By: saitcakmak Differential Revision: D91189850
Summary: The torchx `Runner.stop()` method is deprecated in favor of `cancel()`, which provides identical functionality but is consistent with the CLI and scheduler API naming conventions. This change updates TorchXRunner to use the non-deprecated method, eliminating PendingDeprecationWarning messages during test runs. Reviewed By: saitcakmak Differential Revision: D91190296
mgarrard
force-pushed
the
export-D91190296
branch
from
2697b0a to
32c112c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The torchx
Runner.stop()method is deprecated in favor ofcancel(), which provides identical functionality but is consistent with the CLI and scheduler API naming conventions.This change updates TorchXRunner to use the non-deprecated method, eliminating PendingDeprecationWarning messages during test runs.
Reviewed By: saitcakmak
Differential Revision: D91190296