Skip to content

Conversation

@mgarrard
Copy link
Contributor

Summary: Using test for non-test objects raises warnings from Pytest, this diff renames test classes to mock classes, and puts a flag on testofnoeffect to allow it to not trigger the warning

Reviewed By: saitcakmak

Differential Revision: D91189850

@meta-codesync
Copy link

meta-codesync bot commented Jan 23, 2026

@mgarrard has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91189850.

@meta-cla meta-cla bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 23, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.71%. Comparing base (3417156) to head (b672857).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4815   +/-   ##
=======================================
  Coverage   96.71%   96.71%           
=======================================
  Files         586      586           
  Lines       61307    61308    +1     
=======================================
+ Hits        59296    59297    +1     
  Misses       2011     2011           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mgarrard added a commit to mgarrard/Ax that referenced this pull request Jan 23, 2026
Summary:

Using `test` for non-test objects raises warnings from Pytest, this diff renames test classes to mock classes, and puts a flag on testofnoeffect to allow it to not trigger the warning

Reviewed By: saitcakmak

Differential Revision: D91189850
Summary:

Using `test` for non-test objects raises warnings from Pytest, this diff renames test classes to mock classes, and puts a flag on testofnoeffect to allow it to not trigger the warning

Reviewed By: saitcakmak

Differential Revision: D91189850
mgarrard added a commit to mgarrard/Ax that referenced this pull request Jan 24, 2026
Summary:

Using `test` for non-test objects raises warnings from Pytest, this diff renames test classes to mock classes, and puts a flag on testofnoeffect to allow it to not trigger the warning

Reviewed By: saitcakmak

Differential Revision: D91189850
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants