Only add sq arm when cloning if there is no sq arm present #4805
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4805 +/- ##
=======================================
Coverage 96.71% 96.71%
=======================================
Files 586 586
Lines 61306 61309 +3
=======================================
+ Hits 59294 59297 +3
Misses 2012 2012 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…4805) Summary: When creating an `AuxiliarySource` we hit a bug where we try to add a status quo arm on a `Trial` even if it already has an status quo arm. This diff patches that to first check if the trial has an sq_arm or sq generator run Reviewed By: ItsMrLin Differential Revision: D91177667
eonofrey
force-pushed
the
export-D91177667
branch
from
041f9fc to
5256998
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: When creating an
AuxiliarySourcewe hit a bug where we try to add a status quo arm on aTrialeven if it already has an status quo arm. This diff patches that to first check if the trial has an sq_arm or sq generator runDifferential Revision: D91177667