-
Notifications
You must be signed in to change notification settings - Fork 358
Fix read-only numpy arrays in cross-validation #4794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mgarrard
wants to merge
1
commit into
facebook:main
Choose a base branch
from
mgarrard:export-D91185467
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Prompted after some failures in exports not related to my changes: https://github.com/facebook/Ax/actions/runs/21225324302/job/61070638075?fbclid=IwY2xjawPeXMFleHRuA2FlbQIxMQBicmlkETFRTkR6WlE4NHVrd3IyQXNlc3J0YwZhcHBfaWQBMAABHjTAiZi71n24w95hvzEewrKNPKOGzJisgR7t4qJ3APRMYlusgFC-gu7RLiSb_aem_Zk3pmTDonCFsJvZCTkpeMA Add `.copy()` after `.numpy()` calls to ensure arrays are writeable. PyTorch tensors converted via `.detach().cpu().numpy()` return read-only arrays in some cases. The subsequent squeeze operations create read-only views, and the in-place assignment `loo_covs[:, diag_idx, diag_idx] = loo_vars` fails with "assignment destination is read-only" error. Differential Revision: D91185467
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 22, 2026
Summary: Prompted after some failures in exports not related to my changes: https://github.com/facebook/Ax/actions/runs/21225324302/job/61070638075?fbclid=IwY2xjawPeXMFleHRuA2FlbQIxMQBicmlkETFRTkR6WlE4NHVrd3IyQXNlc3J0YwZhcHBfaWQBMAABHjTAiZi71n24w95hvzEewrKNPKOGzJisgR7t4qJ3APRMYlusgFC-gu7RLiSb_aem_Zk3pmTDonCFsJvZCTkpeMA Add `.copy()` after `.numpy()` calls to ensure arrays are writeable. PyTorch tensors converted via `.detach().cpu().numpy()` return read-only arrays in some cases. The subsequent squeeze operations create read-only views, and the in-place assignment `loo_covs[:, diag_idx, diag_idx] = loo_vars` fails with "assignment destination is read-only" error. Differential Revision: D91185467
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 22, 2026
Summary: Prompted after some failures in exports not related to my changes: https://github.com/facebook/Ax/actions/runs/21225324302/job/61070638075?fbclid=IwY2xjawPeXMFleHRuA2FlbQIxMQBicmlkETFRTkR6WlE4NHVrd3IyQXNlc3J0YwZhcHBfaWQBMAABHjTAiZi71n24w95hvzEewrKNPKOGzJisgR7t4qJ3APRMYlusgFC-gu7RLiSb_aem_Zk3pmTDonCFsJvZCTkpeMA Add `.copy()` after `.numpy()` calls to ensure arrays are writeable. PyTorch tensors converted via `.detach().cpu().numpy()` return read-only arrays in some cases. The subsequent squeeze operations create read-only views, and the in-place assignment `loo_covs[:, diag_idx, diag_idx] = loo_vars` fails with "assignment destination is read-only" error. Differential Revision: D91185467
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 22, 2026
Summary: Prompted after some failures in exports not related to my changes: https://github.com/facebook/Ax/actions/runs/21225324302/job/61070638075?fbclid=IwY2xjawPeXMFleHRuA2FlbQIxMQBicmlkETFRTkR6WlE4NHVrd3IyQXNlc3J0YwZhcHBfaWQBMAABHjTAiZi71n24w95hvzEewrKNPKOGzJisgR7t4qJ3APRMYlusgFC-gu7RLiSb_aem_Zk3pmTDonCFsJvZCTkpeMA Add `.copy()` after `.numpy()` calls to ensure arrays are writeable. PyTorch tensors converted via `.detach().cpu().numpy()` return read-only arrays in some cases. The subsequent squeeze operations create read-only views, and the in-place assignment `loo_covs[:, diag_idx, diag_idx] = loo_vars` fails with "assignment destination is read-only" error. Differential Revision: D91185467
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 22, 2026
Summary: Prompted after some failures in exports not related to my changes: https://github.com/facebook/Ax/actions/runs/21225324302/job/61070638075?fbclid=IwY2xjawPeXMFleHRuA2FlbQIxMQBicmlkETFRTkR6WlE4NHVrd3IyQXNlc3J0YwZhcHBfaWQBMAABHjTAiZi71n24w95hvzEewrKNPKOGzJisgR7t4qJ3APRMYlusgFC-gu7RLiSb_aem_Zk3pmTDonCFsJvZCTkpeMA Add `.copy()` after `.numpy()` calls to ensure arrays are writeable. PyTorch tensors converted via `.detach().cpu().numpy()` return read-only arrays in some cases. The subsequent squeeze operations create read-only views, and the in-place assignment `loo_covs[:, diag_idx, diag_idx] = loo_vars` fails with "assignment destination is read-only" error. Differential Revision: D91185467
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 22, 2026
Summary: Prompted after some failures in exports not related to my changes: https://github.com/facebook/Ax/actions/runs/21225324302/job/61070638075?fbclid=IwY2xjawPeXMFleHRuA2FlbQIxMQBicmlkETFRTkR6WlE4NHVrd3IyQXNlc3J0YwZhcHBfaWQBMAABHjTAiZi71n24w95hvzEewrKNPKOGzJisgR7t4qJ3APRMYlusgFC-gu7RLiSb_aem_Zk3pmTDonCFsJvZCTkpeMA Add `.copy()` after `.numpy()` calls to ensure arrays are writeable. PyTorch tensors converted via `.detach().cpu().numpy()` return read-only arrays in some cases. The subsequent squeeze operations create read-only views, and the in-place assignment `loo_covs[:, diag_idx, diag_idx] = loo_vars` fails with "assignment destination is read-only" error. Differential Revision: D91185467
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 22, 2026
Summary: I'm not sure why these are showing up as failures today, we migrated to Python scientific stack in july 2024, but these are deprecation warnings we should go ahead and take care of anyway. Figured would knock them out while they are causing me issues Prompted after some failures in exports not related to my changes: https://github.com/facebook/Ax/actions/runs/21225324302/job/61070638075?fbclid=IwY2xjawPeXMFleHRuA2FlbQIxMQBicmlkETFRTkR6WlE4NHVrd3IyQXNlc3J0YwZhcHBfaWQBMAABHjTAiZi71n24w95hvzEewrKNPKOGzJisgR7t4qJ3APRMYlusgFC-gu7RLiSb_aem_Zk3pmTDonCFsJvZCTkpeMA Add `.copy()` after `.numpy()` calls to ensure arrays are writeable. PyTorch tensors converted via `.detach().cpu().numpy()` return read-only arrays in some cases. The subsequent squeeze operations create read-only views, and the in-place assignment `loo_covs[:, diag_idx, diag_idx] = loo_vars` fails with "assignment destination is read-only" error. Differential Revision: D91185467
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4794 +/- ##
=======================================
Coverage 96.70% 96.70%
=======================================
Files 587 587
Lines 61294 61294
=======================================
+ Hits 59273 59275 +2
+ Misses 2021 2019 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 22, 2026
Summary: I'm not sure why these are showing up as failures today, we migrated to Python scientific stack in july 2024, but these are deprecation warnings we should go ahead and take care of anyway. Figured would knock them out while they are causing me issues Prompted after some failures in exports not related to my changes: https://github.com/facebook/Ax/actions/runs/21225324302/job/61070638075?fbclid=IwY2xjawPeXMFleHRuA2FlbQIxMQBicmlkETFRTkR6WlE4NHVrd3IyQXNlc3J0YwZhcHBfaWQBMAABHjTAiZi71n24w95hvzEewrKNPKOGzJisgR7t4qJ3APRMYlusgFC-gu7RLiSb_aem_Zk3pmTDonCFsJvZCTkpeMA Add `.copy()` after `.numpy()` calls to ensure arrays are writeable. PyTorch tensors converted via `.detach().cpu().numpy()` return read-only arrays in some cases. The subsequent squeeze operations create read-only views, and the in-place assignment `loo_covs[:, diag_idx, diag_idx] = loo_vars` fails with "assignment destination is read-only" error. Differential Revision: D91185467
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 22, 2026
Summary: I'm not sure why these are showing up as failures today, we migrated to Python scientific stack in july 2024, but these are deprecation warnings we should go ahead and take care of anyway. Figured would knock them out while they are causing me issues Prompted after some failures in exports not related to my changes: https://github.com/facebook/Ax/actions/runs/21225324302/job/61070638075?fbclid=IwY2xjawPeXMFleHRuA2FlbQIxMQBicmlkETFRTkR6WlE4NHVrd3IyQXNlc3J0YwZhcHBfaWQBMAABHjTAiZi71n24w95hvzEewrKNPKOGzJisgR7t4qJ3APRMYlusgFC-gu7RLiSb_aem_Zk3pmTDonCFsJvZCTkpeMA Add `.copy()` after `.numpy()` calls to ensure arrays are writeable. PyTorch tensors converted via `.detach().cpu().numpy()` return read-only arrays in some cases. The subsequent squeeze operations create read-only views, and the in-place assignment `loo_covs[:, diag_idx, diag_idx] = loo_vars` fails with "assignment destination is read-only" error. Differential Revision: D91185467
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 22, 2026
Summary: I'm not sure why these are showing up as failures today, we migrated to Python scientific stack in july 2024, but these are deprecation warnings we should go ahead and take care of anyway. Figured would knock them out while they are causing me issues Prompted after some failures in exports not related to my changes: https://github.com/facebook/Ax/actions/runs/21225324302/job/61070638075?fbclid=IwY2xjawPeXMFleHRuA2FlbQIxMQBicmlkETFRTkR6WlE4NHVrd3IyQXNlc3J0YwZhcHBfaWQBMAABHjTAiZi71n24w95hvzEewrKNPKOGzJisgR7t4qJ3APRMYlusgFC-gu7RLiSb_aem_Zk3pmTDonCFsJvZCTkpeMA Add `.copy()` after `.numpy()` calls to ensure arrays are writeable. PyTorch tensors converted via `.detach().cpu().numpy()` return read-only arrays in some cases. The subsequent squeeze operations create read-only views, and the in-place assignment `loo_covs[:, diag_idx, diag_idx] = loo_vars` fails with "assignment destination is read-only" error. Differential Revision: D91185467
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 22, 2026
Summary: I'm not sure why these are showing up as failures today, we migrated to Python scientific stack in july 2024, but these are deprecation warnings we should go ahead and take care of anyway. Figured would knock them out while they are causing me issues Prompted after some failures in exports not related to my changes: https://github.com/facebook/Ax/actions/runs/21225324302/job/61070638075?fbclid=IwY2xjawPeXMFleHRuA2FlbQIxMQBicmlkETFRTkR6WlE4NHVrd3IyQXNlc3J0YwZhcHBfaWQBMAABHjTAiZi71n24w95hvzEewrKNPKOGzJisgR7t4qJ3APRMYlusgFC-gu7RLiSb_aem_Zk3pmTDonCFsJvZCTkpeMA Add `.copy()` after `.numpy()` calls to ensure arrays are writeable. PyTorch tensors converted via `.detach().cpu().numpy()` return read-only arrays in some cases. The subsequent squeeze operations create read-only views, and the in-place assignment `loo_covs[:, diag_idx, diag_idx] = loo_vars` fails with "assignment destination is read-only" error. Differential Revision: D91185467
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 22, 2026
Summary: I'm not sure why these are showing up as failures today, we migrated to Python scientific stack in july 2024, but these are deprecation warnings we should go ahead and take care of anyway. Figured would knock them out while they are causing me issues Prompted after some failures in exports not related to my changes: https://github.com/facebook/Ax/actions/runs/21225324302/job/61070638075?fbclid=IwY2xjawPeXMFleHRuA2FlbQIxMQBicmlkETFRTkR6WlE4NHVrd3IyQXNlc3J0YwZhcHBfaWQBMAABHjTAiZi71n24w95hvzEewrKNPKOGzJisgR7t4qJ3APRMYlusgFC-gu7RLiSb_aem_Zk3pmTDonCFsJvZCTkpeMA Add `.copy()` after `.numpy()` calls to ensure arrays are writeable. PyTorch tensors converted via `.detach().cpu().numpy()` return read-only arrays in some cases. The subsequent squeeze operations create read-only views, and the in-place assignment `loo_covs[:, diag_idx, diag_idx] = loo_vars` fails with "assignment destination is read-only" error. Differential Revision: D91185467
mgarrard
added a commit
to mgarrard/Ax
that referenced
this pull request
Jan 22, 2026
Summary: I'm not sure why these are showing up as failures today, we migrated to Python scientific stack in july 2024, but these are deprecation warnings we should go ahead and take care of anyway. Figured would knock them out while they are causing me issues Prompted after some failures in exports not related to my changes: https://github.com/facebook/Ax/actions/runs/21225324302/job/61070638075?fbclid=IwY2xjawPeXMFleHRuA2FlbQIxMQBicmlkETFRTkR6WlE4NHVrd3IyQXNlc3J0YwZhcHBfaWQBMAABHjTAiZi71n24w95hvzEewrKNPKOGzJisgR7t4qJ3APRMYlusgFC-gu7RLiSb_aem_Zk3pmTDonCFsJvZCTkpeMA Add `.copy()` after `.numpy()` calls to ensure arrays are writeable. PyTorch tensors converted via `.detach().cpu().numpy()` return read-only arrays in some cases. The subsequent squeeze operations create read-only views, and the in-place assignment `loo_covs[:, diag_idx, diag_idx] = loo_vars` fails with "assignment destination is read-only" error. Differential Revision: D91185467
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Prompted after some failures in exports not related to my changes: https://github.com/facebook/Ax/actions/runs/21225324302/job/61070638075?fbclid=IwY2xjawPeXMFleHRuA2FlbQIxMQBicmlkETFRTkR6WlE4NHVrd3IyQXNlc3J0YwZhcHBfaWQBMAABHjTAiZi71n24w95hvzEewrKNPKOGzJisgR7t4qJ3APRMYlusgFC-gu7RLiSb_aem_Zk3pmTDonCFsJvZCTkpeMA
Add
.copy()after.numpy()calls to ensure arrays are writeable.PyTorch tensors converted via
.detach().cpu().numpy()return read-onlyarrays in some cases. The subsequent squeeze operations create read-only
views, and the in-place assignment
loo_covs[:, diag_idx, diag_idx] = loo_varsfails with "assignment destination is read-only" error.
Differential Revision: D91185467