feat: add macro expansion capability to Analysis and Indexer#559
Open
Draggu wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Seems like it won't work on 1.16 due to missing |
Member
|
Regarding the polyfills, I personally think that if it's only Elixir 1.16 that's affected and it's basically a new functionality, it would be ok to guard around the version and not offer this for Elixir 1.16 users. Not sure what others think. |
Contributor
|
I agree with @katafrakt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #517 #536
This PR uses Spitfire expand to get macro expansions in
Analysis, then indexer can visit expanded asts too. There is assumption that all generataed code will be pointing to whole macro call. Making it more precise is complex and can be done on top of this PR