Migrated CLI and settings to Rust#2163
Draft
AndreiCravtov wants to merge 79 commits into
Draft
Conversation
# Conflicts: # Cargo.lock # rust/exo_rs/Cargo.toml # rust/exo_rs/exo_rs.pyi # rust/exo_rs/src/lib.rs # rust/exo_rs/src/networking.rs # src/exo/main.py
need to update build scripts for this
added to/from bytes + reduce + set module so it isn't builtins.<Class>
… references that is supposed to replace Py<T> such that it is parse-able from the CLI and Serde - and hence we can have NORMAL getters/setters without weird copy behaviour
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We need a nice unified place to resolve all the configuration/cli args/env flags etc. Rust has a very nice library for that. Hence I moved CLI parsing + settings to Rust.
This is a precursor feature to Evan's distributed settings.
Changes
Why It Works
Test Plan
Manual Testing
Automated Testing