🔖 release: mobile@1.1.11, server@0.2.61#754
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughRemoves three provisional changeset files, bumps Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @cruzdanilo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated release generated by the Changesets action. Its primary purpose is to publish a new patch version of the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is an automated release for @exactly/server version 0.2.61. The changes correctly update the package version and changelog. The underlying code changes, which improve Sentry error fingerprinting, were also reviewed. While the new fingerprinting logic is a good improvement, I noticed the logic is duplicated across server/hooks/block.ts, server/hooks/activity.ts, and server/utils/keeper.ts. To improve maintainability, this could be refactored into a shared utility function in a follow-up change. As these files are not in the diff, I'm providing this feedback here.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #754 +/- ##
==========================================
+ Coverage 67.81% 68.16% +0.34%
==========================================
Files 206 206
Lines 7032 7093 +61
Branches 2210 2229 +19
==========================================
+ Hits 4769 4835 +66
+ Misses 2063 2060 -3
+ Partials 200 198 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9c4418f to
43c76b4
Compare
43c76b4 to
35c37fa
Compare
35c37fa to
4d8bcfe
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@exactly/mobile@1.1.11
Patch Changes
#753
53f75e7Thanks @cruzdanilo! - 🥅 catch biometric error in passkey creationUpdated dependencies [
5f4b287,7fa2fa3,520573b,c3098bd,03fdfa3,6d8bc73,4a6c836]:@exactly/server@0.2.61
Patch Changes
#744
5f4b287Thanks @cruzdanilo! - 🥅 fingerprint block hook errors#756
7fa2fa3Thanks @mainqueg! - 🏷️ normalize sentry event names#755
520573bThanks @cruzdanilo! - 🦺 acknowledge panda dispute events#756
c3098bdThanks @mainqueg! - 🥅 catch invalid legal id during manteca onboarding#758
03fdfa3Thanks @nfmelendez! - 🥅 skip retries for replay reverts#756
6d8bc73Thanks @mainqueg! - 📈 track onramp and ramp account events#744
4a6c836Thanks @cruzdanilo! - 🥅 fingerprint poke errors in activity hookSummary by CodeRabbit
Bug Fixes
Chores