-
Notifications
You must be signed in to change notification settings - Fork 2
🔖 release: [email protected], [email protected] #677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @cruzdanilo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated release for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
WalkthroughRemoved multiple .changeset files, bumped Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, generated by the Changesets release action, prepares for the v0.2.51 release of the @exactly/server package. The changes are confined to versioning and documentation updates: the version in package.json is bumped, the CHANGELOG.md is updated to reflect the new patch changes, and the source changeset files are deleted. These modifications are standard for an automated release process and appear to be correct. No issues were found in this review.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #677 +/- ##
=======================================
Coverage 61.07% 61.07%
=======================================
Files 169 169
Lines 5236 5236
Branches 1461 1461
=======================================
Hits 3198 3198
Misses 1876 1876
Partials 162 162
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@server/CHANGELOG.md`:
- Around line 3-9: Normalize the prose in the "## 0.2.51" changelog entry to use
lowercase (e.g., change "Thanks" to "thanks") and rewrap the two long bullet
lines for PR `#674` (commit ids `71418d1` and `3430400`) so each line is <=120
characters; update the two bullets under "Patch Changes" to use lowercase
wording and split long sentences into shorter lines without altering content or
links.
| ## 0.2.51 | ||
|
|
||
| ### Patch Changes | ||
|
|
||
| - [#674](https://github.com/exactly/exa/pull/674) [`71418d1`](https://github.com/exactly/exa/commit/71418d18eb9f4d1def1921d1edcdb0e4555fd642) Thanks [@nfmelendez](https://github.com/nfmelendez)! - 🗃️ add source to credentials database table | ||
|
|
||
| - [#674](https://github.com/exactly/exa/pull/674) [`3430400`](https://github.com/exactly/exa/commit/343040061995e47764859080f7dcace6c33c435c) Thanks [@nfmelendez](https://github.com/nfmelendez)! - ✨ track user source attribution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normalize casing and wrap long lines in the 0.2.51 entry.
Line 5 uses capitalized prose, and Lines 7/9 exceed 120 characters. Markdown guidelines require lowercase prose and line length <=120.
📝 Proposed fix
-### Patch Changes
+### patch changes
-- [`#674`](https://github.com/exactly/exa/pull/674) [`71418d1`](https://github.com/exactly/exa/commit/71418d18eb9f4d1def1921d1edcdb0e4555fd642) Thanks [`@nfmelendez`](https://github.com/nfmelendez)! - 🗃️ add source to credentials database table
+- [`#674`](https://github.com/exactly/exa/pull/674)
+ [`71418d1`](https://github.com/exactly/exa/commit/71418d18eb9f4d1def1921d1edcdb0e4555fd642)
+ thanks [`@nfmelendez`](https://github.com/nfmelendez)! - 🗃️ add source to credentials database table
-- [`#674`](https://github.com/exactly/exa/pull/674) [`3430400`](https://github.com/exactly/exa/commit/343040061995e47764859080f7dcace6c33c435c) Thanks [`@nfmelendez`](https://github.com/nfmelendez)! - ✨ track user source attribution
+- [`#674`](https://github.com/exactly/exa/pull/674)
+ [`3430400`](https://github.com/exactly/exa/commit/343040061995e47764859080f7dcace6c33c435c)
+ thanks [`@nfmelendez`](https://github.com/nfmelendez)! - ✨ track user source attribution🤖 Prompt for AI Agents
In `@server/CHANGELOG.md` around lines 3 - 9, Normalize the prose in the "##
0.2.51" changelog entry to use lowercase (e.g., change "Thanks" to "thanks") and
rewrap the two long bullet lines for PR `#674` (commit ids `71418d1` and
`3430400`) so each line is <=120 characters; update the two bullets under "Patch
Changes" to use lowercase wording and split long sentences into shorter lines
without altering content or links.
6770268 to
c482559
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@CHANGELOG.md`:
- Around line 3-11: The changelog entry uses title-case and has lines exceeding
120 characters (see headings "## 1.1.3" and "### Patch Changes" and the long
dependency lines); update the entry to use lowercase markdown prose and wrap
long lines to <=120 characters, or better yet update the Changesets changelog
template so generated entries use lowercase headings and wrapped lines—apply the
change to the current "## 1.1.3" block and the long dependency/commit lines so
they comply with the project's lowercase and line-length rules.
♻️ Duplicate comments (1)
server/CHANGELOG.md (1)
3-10: Casing and line-length issues in the changelog entry.The issues with capitalized prose ("Patch Changes", "Thanks") and lines exceeding 120 characters have already been flagged in a previous review.
| ## 1.1.3 | ||
|
|
||
| ### Patch Changes | ||
|
|
||
| - [#678](https://github.com/exactly/exa/pull/678) [`bc8ac76`](https://github.com/exactly/exa/commit/bc8ac764d34ee857596a8fa926f67260926000e4) Thanks [@cruzdanilo](https://github.com/cruzdanilo)! - 🐛 skip pending queries in dehydration to prevent hydration crash | ||
|
|
||
| - Updated dependencies [[`71418d1`](https://github.com/exactly/exa/commit/71418d18eb9f4d1def1921d1edcdb0e4555fd642), [`3430400`](https://github.com/exactly/exa/commit/343040061995e47764859080f7dcace6c33c435c)]: | ||
| - @exactly/[email protected] | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial
Casing and line-length issues in the changelog entry.
Per coding guidelines, markdown prose should be lowercase and lines should not exceed 120 characters. However, this entry follows the same Changesets-generated format used throughout the existing changelog (e.g., lines 12-16 and beyond), so this appears to be the established project pattern.
If strict guideline adherence is desired, consider configuring the Changesets changelog template to output lowercase headings and wrap long lines.
🤖 Prompt for AI Agents
In `@CHANGELOG.md` around lines 3 - 11, The changelog entry uses title-case and
has lines exceeding 120 characters (see headings "## 1.1.3" and "### Patch
Changes" and the long dependency lines); update the entry to use lowercase
markdown prose and wrap long lines to <=120 characters, or better yet update the
Changesets changelog template so generated entries use lowercase headings and
wrapped lines—apply the change to the current "## 1.1.3" block and the long
dependency/commit lines so they comply with the project's lowercase and
line-length rules.
de85ef4 to
7990875
Compare
7990875 to
8efbd46
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@exactly/[email protected]
Patch Changes
#678
bc8ac76Thanks @cruzdanilo! - 🐛 skip pending queries in dehydration to prevent hydration crash#682
eeb8a43Thanks @franm91! - ♻️ filter server queries from persistence#682
8059d4aThanks @franm91! - 🐛 invalidate kyc query on version change#683
8780581Thanks @dieguezguille! - ✨ implement persona web sdkUpdated dependencies [
71418d1,3430400]:@exactly/[email protected]
Patch Changes
#674
71418d1Thanks @nfmelendez! - 🗃️ add source to credentials database table#674
3430400Thanks @nfmelendez! - ✨ track user source attributionSummary by CodeRabbit
New Features
Bug Fixes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.