Skip to content

chore: Fix mismatched comment in TestCache_WithNilStore function #3074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julienrbrt merged 1 commit into from
Feb 16, 2026
Merged

chore: Fix mismatched comment in TestCache_WithNilStore function #3074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion block/internal/cache/generic_cache_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ func TestCache_DeleteAllForHeight(t *testing.T) {
assert.True(t, c.isSeen("hash2"))
}

// TestCacheWithConfig tests creating cache with custom config
// TestCache_WithNilStore tests creating cache with nil store
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Thank you for fixing the mismatched comment. To further improve clarity, consider making the comment explain the purpose of the test rather than repeating what is already clear from the function name. A more descriptive comment explaining the 'why' of the test would be more helpful for future readers and is consistent with other high-quality test comments in this file.

Suggested change
// TestCache_WithNilStore tests creating cache with nil store
// TestCache_WithNilStore verifies that the cache operates correctly without a backing store.

func TestCache_WithNilStore(t *testing.T) {
// Cache without store should work fine
c := NewCache[testItem](nil, "")
Expand Down
Loading