fix(snapshot): add integrity verification and preserve execution limits#1026
Merged
fix(snapshot): add integrity verification and preserve execution limits#1026
Conversation
- Add SHA-256 digest to snapshot serialization to detect tampering - Tampered or truncated snapshots are rejected with clear error - Fix JS bindings from_snapshot() to accept BashOptions for limits - from_snapshot() now builds a properly configured instance via build_bash() then restores snapshot state, preserving limits Closes #977 Closes #978
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
from_snapshot()to acceptBashOptionsfor re-applying limitsfrom_snapshot()now builds a properly configured instance viabuild_bash()then restores snapshot state, preserving execution limitsWhy
Snapshots had no integrity protection — an attacker could modify serialized bytes to inject variables, tamper VFS contents, or bypass execution limits. Additionally,
from_snapshot()in the JS bindings createdSharedStatewithmax_commands: None, removing all DoS protection.Tests
snapshot_tampered_bytes_rejected— modified payload is rejectedsnapshot_truncated_rejected— too-short data is rejectedsnapshot_modified_digest_rejected— modified digest is rejectedrestore_snapshot_preserves_limits— limits survive snapshot/restore cycleCloses #977
Closes #978