Skip to content
This repository was archived by the owner on Apr 16, 2025. It is now read-only.

Verification code button style update - #159

Closed
daileytj wants to merge 5 commits into
release/4.2.0from
bug/3269-verification-code-button-style-update
Closed

Verification code button style update#159
daileytj wants to merge 5 commits into
release/4.2.0from
bug/3269-verification-code-button-style-update

Conversation

@daileytj

@daileytj daileytj commented Jul 1, 2022

Copy link
Copy Markdown
Contributor

BLUI-3269
Fixes #157

Changes proposed in this Pull Request:

  • Verification code button style update

Screenshots:

To Test:

  • Clone react-native-workflow project
  • Initialize react-auth-shared submodule using branch feature/3269-add-verification-code-prompt-translation-text
  • yarn start:example
  • Go to self registration workflow (click debug button, then click self-registration button)
  • Navigate to the third screen in the workflow to visit the verification code page
  • Observe the updated view

@daileytj

daileytj commented Jul 1, 2022

Copy link
Copy Markdown
Contributor Author

https://github.com/brightlayer-ui/react-native-workflows/issues/157#issuecomment-1172617553 will need addressed before I switch this to an active pull request

@daileytj daileytj changed the title Cerification code button style update Verification code button style update Jul 1, 2022
@daileytj
daileytj marked this pull request as ready for review July 5, 2022 19:59
@daileytj

daileytj commented Jul 5, 2022

Copy link
Copy Markdown
Contributor Author

Running into testing issues and I can't seem to track down what change caused this. ptelad/react-native-iphone-x-helper#38

@daileytj

daileytj commented Jul 6, 2022

Copy link
Copy Markdown
Contributor Author

Made a PR into the react-native-iphone-helper repo: ptelad/react-native-iphone-x-helper#41

this fixes the first issue I ran into, but now I'm getting a new issue shown in the screenshot below.
I've already tried to clear the jest cache as well. I'm thinking there is some bigger underlying issue I can't quite figure out.

Screen Shot 2022-07-06 at 3 09 33 PM

@ektasawant

ektasawant commented Jul 7, 2022

Copy link
Copy Markdown
Contributor

Screenshot 2022-07-07 at 12 27 05 PM

Changes looks fine.

@daileytj

daileytj commented Jul 7, 2022

Copy link
Copy Markdown
Contributor Author

@daileytj daileytj closed this Jul 7, 2022
@daileytj
daileytj deleted the bug/3269-verification-code-button-style-update branch July 7, 2022 13:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants