Implemented functionalities to allow multiple LDAP configs#281
Open
Riccardo-Maffei wants to merge 2 commits intoetianen:masterfrom
Open
Implemented functionalities to allow multiple LDAP configs#281Riccardo-Maffei wants to merge 2 commits intoetianen:masterfrom
Riccardo-Maffei wants to merge 2 commits intoetianen:masterfrom
Conversation
…meter was missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there! I had to use multiple configurations for my Django Application and i was already using this package, so I tried to implement the functionality myself. I've tested it a bit and up until now it seems to be working, but documentation is still mostly missing.
With this implementation, the user would need to implement a subclass of the LDAP Backend class
and add the required data to settings.py. If the value of a specific setting does not change across LDAP Backends, the user can stick to the default name (no prefix). Thanks to this feature, the new code is entirely compatible with programs that use previous versions of the python3-ldap package.
What do you think about it?