feat(discord/build): surface ethrex in /build client-el#156
Closed
barnabasbusa wants to merge 1 commit into
Closed
feat(discord/build): surface ethrex in /build client-el#156barnabasbusa wants to merge 1 commit into
barnabasbusa wants to merge 1 commit into
Conversation
Cartographoor's remote data does not list ethrex yet, but the build-push-ethrex.yml workflow already exists upstream. Carry a small local override so the EL dropdown picks it up and the tool list does not double-list it.
Member
|
no |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extraClientsByType) in the build command soethrexshows up in the/build client-eldropdown even though Cartographoor's remote data doesn't list it yet.eth-client-docker-image-builder(build-push-ethrex.yml— present), so unknown additions silently drop off rather than producing dead choices.GetToolWorkflowsso ethrex doesn't double-list under/build tool.Notes
ethrexand the triggered-build embed uses the default panda thumbnail (no logo). The right long-term fix is to add ethrex upstream in Cartographoor'snetworks.json; this PR is the local stop-gap.Test plan
/build client-elshowsethrexas an option in Discord/build toolno longer listsethrex/build client-el client:ethrexdispatchesbuild-push-ethrex.ymland the inline embed renders without error