Warn users about impact of backfill #1877
Conversation
| useMount(() => { | ||
| logRocketEvent('Data_Flow_Reset', { | ||
| confirmationShown: true, | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Just to be safe adding some eventing so we know what this happens.
| } else { | ||
| void save(draftId); | ||
| } |
There was a problem hiding this comment.
Put inside an else just to be super safe. Normally we return up above but on the off change that ever gets messed up I don't want save run twice.
| // Save "do not show again" preference to local storage if applicable | ||
| if (doNotShowAgain && settings.doNotShowAgainStorageKey) { | ||
| localStorage.setItem( | ||
| settings.doNotShowAgainStorageKey, | ||
| SKIP_CONFIRMATION_VALUE | ||
| ); | ||
| } |
There was a problem hiding this comment.
Thought to only save if they confirmed. Saving right away when updating the setting felt wrong if the user clicked cancel
| if (userSettings.doNotShowAgainStorageKey) { | ||
| if ( | ||
| localStorage.getItem( | ||
| userSettings.doNotShowAgainStorageKey | ||
| ) === SKIP_CONFIRMATION_VALUE | ||
| ) { | ||
| logRocketEvent('Confirmation', { | ||
| status: 'skipped', | ||
| localStorageKey: userSettings.doNotShowAgainStorageKey, | ||
| }); | ||
| return Promise.resolve(true); | ||
| } | ||
| } |
There was a problem hiding this comment.
In the future I could see us need a "skip confirm" for lots of things but for now we only have 1 use case.
| > | ||
| <DialogTitle id={LABEL_ID}> | ||
| <FormattedMessage id={settings.title} /> | ||
| {intl.formatMessage({ id: settings.title })} |
There was a problem hiding this comment.
Switching out to hook.
| {typeof settings.message === 'string' && | ||
| settings.message.length > 0 | ||
| ? intl.formatMessage({ id: settings.message }) | ||
| : settings.message} |
There was a problem hiding this comment.
Switching out to hook and this is the first time an exception got thrown.
The component more gracefully handled empty keys.
| export enum CustomEvents { | ||
| AUTHORIZE_TASK = 'AuthorizeTask', | ||
| AUTH_SIGNOUT = 'Auth_Signout', | ||
| DATA_FLOW_RESET = 'Data_Flow_Reset', |
There was a problem hiding this comment.
This was not being used so moved to the new type
src/components/editor/Bindings/Backfill/PreSaveConfirmation.tsx
Outdated
Show resolved
Hide resolved
Issues
#1868
Changes
1868
confirmationto the save button clickMisc
intlhooksTests
Manually tested
Automated tests
Playwright tests ran locally
Screenshots
New confirmation for captures about backfill when saving
LocalStorage saved