Update to TS 5 #1875
Merged
Update to TS 5 #1875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of update to TS5
GregorShear
commented
Jan 21, 2026
also removed obsolete @typescript-eslint/no-implicit-any-catch disable comments and changed catch clause types from `any` to `unknown`.
GregorShear
changed the title
suppressImplicitAnyIndexErrors flag and address errors
GregorShear
commented
Jan 21, 2026
tsconfig.json
Outdated
Comment on lines
37
to
39
| "types": ["vite/client"] | ||
| }, | ||
| "include": ["src", "deps/flow/flow.d.ts", "deps/supabase/types.d.ts"], | ||
| "include": ["src", "deps/flow/flow.d.ts", "deps/supabase/types.d.ts", "__mocks__/vitest-env.d.ts"], |
Contributor
Author
There was a problem hiding this comment.
i'm new to vitest - is this a safe change to make?
Member
There was a problem hiding this comment.
That is a great question... I will have to do some digging.
My initial thoughts it no. Reason being it feels wonky to me to include mock stuff here.
GregorShear
added
dependencies
travjenkins
reviewed
Jan 29, 2026
Comment on lines
6308
to
5844
| "node_modules/dayjs": { | ||
| "version": "1.11.19", | ||
| "resolved": "https://registry.npmjs.org/dayjs/-/dayjs-1.11.19.tgz", | ||
| "integrity": "sha512-t5EcLVS6QPBNqM2z8fakk/NKel+Xzshgt8FFKAn+qwlD1pzZWxh0nVCrvFK7ZDb6XucZeF9z8C7CBWTRIVApAw==", | ||
| "optional": true, | ||
| "peer": true | ||
| }, |
Member
There was a problem hiding this comment.
This getting removed is an issue. Even though we do not consume it our mui date input does.
Member
There was a problem hiding this comment.
What version of NPM and Node are you running / ran while you did this work?
No longer need to manually include types in tsconfig
Marking the type we are expecting
the typing too much here
travjenkins
approved these changes
Jan 29, 2026
Member
travjenkins
left a comment
travjenkins
left a comment
There was a problem hiding this comment.
lgtm - pushed some changes that were very nit picky.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
https://github.com/estuary/ui/issues/issue_number
Changes
issue_number
Tests
Manually tested
Automated tests
Playwright tests ran locally
Screenshots
If applicable - please include some screenshots of the new UI