Enable the specification of alert types when creating or editing an alert subscription#1858
Merged
kiahna-tucker merged 120 commits intomainfrom Apr 9, 2026
Merged
Conversation
travjenkins
reviewed
Apr 8, 2026
travjenkins
reviewed
Apr 8, 2026
travjenkins
reviewed
Apr 8, 2026
travjenkins
reviewed
Apr 8, 2026
travjenkins
reviewed
Apr 8, 2026
travjenkins
reviewed
Apr 8, 2026
travjenkins
reviewed
Apr 8, 2026
travjenkins
reviewed
Apr 9, 2026
kiahna-tucker
deleted the
kiahna-tucker/notifications/view-and-set-alert-types
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
The issues directly below are completely resolved by this PR:
#1859
Changes
1859
The following features are included in this PR:
Replace the
alert_subscriptions, Supabase endpoints that power notification-related views on the Settings tab of the Admin page with their GraphQL counterparts.Virtualize the Organization Notifications table on the Settings tab of the Admin page.
Add an Alert Types form field to the alert subscriptions dialogs, which share a root component.
Update the UX of the alert subscriptions dialogs to allow for the creation or edit of a single subscription.
Enable the deletion of an existing alert subscription via the Update Notification Methods (edit) dialog.
NOTE: Please see corresponding issue(s) for the outline of base requirements addressed by this PR.
Tests
Manually tested
Approaches to testing are as follows:
Validate that an alert subscription can be created, updated, and deleted in the client.
Validate that the alert types array of a new alert subscription will be defaulted if unspecified.
Validate that the contents of the Alert Types table cells can be expanded and scrolled in Chrome, Edge, and Firefox. This functionality must be tested in Safari before this PR can be merged.
Playwright tests ran locally
Screenshots
Table
Organization Notifications table | Default
Organization Notifications table | With more than ten rows
Organization Notifications table | Row with alert types chip list expanded
Dialog
Configure Notification Methods dialog | Administrator of one prefix | Opened
Configure Notification Methods dialog | Administrator of multiple prefixes | Opened
Configure Notification Methods dialog | Error alert displayed
Update Notification Methods dialog | Opened
Alert Types field | Menu expanded
Fallback error alert | Subscription creation or modification failed
Fallback error alert | Subscription deletion failed