IEP-1699: Use CDT build environment for idf_tools.py list command#1394
IEP-1699: Use CDT build environment for idf_tools.py list command#1394kolipakakondal wants to merge 1 commit intomasterfrom
Conversation
📝 WalkthroughWalkthroughAbstractToolsHandler.java refactored to obtain system environment variables through a centralized Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
The AbstractToolsHandler.runCommand() was using System.getenv() which only
includes OS system environment variables, but not the CDT build environment
variables set by the IDE (like IDF_TOOLS_PATH).
Fixes # (IEP-1699)
Type of change
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Dependent components impacted by this PR:
Checklist
Summary by CodeRabbit