fix(styles): improve light theme contrast for semantic colors, diffs, and syntax highlighting#3372
Merged
Conversation
… and syntax highlighting - Override --ok/--warn/--err in light theme with V1 values (#15803d, #b45309, #dc2626) — previously inherited dark-theme values with insufficient contrast (1.8-2.8:1, now 4.2-6.5:1, WCAG AA). - Add light-theme --add-bg/--del-bg/--add-fg/--del-fg so diff markers are readable on white backgrounds instead of inheriting dark tones. - Add light-theme --hl-* syntax-highlight palette (GitHub-inspired) so code blocks in light mode are legible instead of displaying dark-mode neon colors on white. - Detach .hljs-addition from --hl-string and add .hljs-deletion — both now use --add-fg/--del-fg respectively so diff inline changes match the diff-gutter color. - Add REASONIX_DEV=1 to the dev script.
github-actions
Bot
added
desktop
ListBranches sorts by CreatedAt then ID, but Windows filesystem timestamp resolution is too coarse — two files created rapidly share the same timestamp, so the ID tiebreaker (child < root) puts child first. Replace positional assertions with ID-based lookups.
github-actions
Bot
added
the
agent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Override --ok/--warn/--err in light theme with V1 values (#15803d, #b45309, #dc2626) — previously inherited dark-theme values with insufficient contrast (1.8-2.8:1, now 4.2-6.5:1, WCAG AA).
Add light-theme --add-bg/--del-bg/--add-fg/--del-fg so diff markers are readable on white backgrounds instead of inheriting dark tones.
Add light-theme --hl-* syntax-highlight palette (GitHub-inspired) so code blocks in light mode are legible instead of displaying dark-mode neon colors on white.
Detach .hljs-addition from --hl-string and add .hljs-deletion — both now use --add-fg/--del-fg respectively so diff inline changes match the diff-gutter color.