Refine desktop settings center / 优化桌面设置中心#3347
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6ccc15b810
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return; | ||
| } | ||
| const currentDefault = p.default && fetched.includes(p.default) ? p.default : fetched[0]; | ||
| await app.SaveProvider({ ...p, models: fetched, default: currentDefault }); |
There was a problem hiding this comment.
Preserve provider-only fields when refreshing models
When a user refreshes models for an existing provider, this sends the frontend ProviderView back through SaveProvider; that view does not carry provider-only config such as no_proxy or price, while UpsertProvider replaces the whole entry. For the new official Mimo templates that set NoProxy: true (and for any priced existing provider), clicking refresh silently clears those fields, so subsequent requests can stop bypassing the proxy for endpoints that require it and cost reporting is lost. Please update only the model list/default here or round-trip the hidden provider fields.
Useful? React with 👍 / 👎.
|
Superseded by the newly split main-v2 based PRs, especially #3365 for settings navigation copy and #3366/#3368 for the related desktop UI work. This PR is broader than the remaining review scope and overlaps with the focused PR stack, so it is being closed. Any remaining provider/model configuration pieces can be resubmitted as a smaller dedicated PR. |
Summary
Verification