Skip to content

Refine desktop settings center / 优化桌面设置中心#3347

Closed
SivanCola wants to merge 1 commit into
main-v2from
codex/settings-center-memory-redesign
Closed

Refine desktop settings center / 优化桌面设置中心#3347
SivanCola wants to merge 1 commit into
main-v2from
codex/settings-center-memory-redesign

Conversation

@SivanCola
Copy link
Copy Markdown
Collaborator

Summary

  • Rework the desktop settings center into a unified modal with embedded MCP, Skills, and Memory pages.
  • Refine model provider access: official/custom provider flows, model discovery, effort mapping, and provider key handling.
  • Redesign Memory settings into Memory entries and Instruction files, with inline add-memory and scoped instruction previews.

Verification

  • npm run build (desktop/frontend)
  • go test ./internal/config ./internal/provider/openai
  • go test . -run 'Test(RemoveEnvFileDeletesKeyAndUnsetsProcessEnv|UpsertEnvFile|PromoteProviderKeys|Settings|Provider|TabProfile)' (desktop)\n- Browser checks for settings control alignment, custom provider flow, and Memory tab structure\n

@SivanCola SivanCola requested a review from esengine as a code owner June 6, 2026 09:23
@github-actions github-actions Bot added the v2 Go rewrite (1.x) — main-v2 branch, active development label Jun 6, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6ccc15b810

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

return;
}
const currentDefault = p.default && fetched.includes(p.default) ? p.default : fetched[0];
await app.SaveProvider({ ...p, models: fetched, default: currentDefault });
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve provider-only fields when refreshing models

When a user refreshes models for an existing provider, this sends the frontend ProviderView back through SaveProvider; that view does not carry provider-only config such as no_proxy or price, while UpsertProvider replaces the whole entry. For the new official Mimo templates that set NoProxy: true (and for any priced existing provider), clicking refresh silently clears those fields, so subsequent requests can stop bypassing the proxy for endpoints that require it and cost reporting is lost. Please update only the model list/default here or round-trip the hidden provider fields.

Useful? React with 👍 / 👎.

@SivanCola
Copy link
Copy Markdown
Collaborator Author

Superseded by the newly split main-v2 based PRs, especially #3365 for settings navigation copy and #3366/#3368 for the related desktop UI work. This PR is broader than the remaining review scope and overlaps with the focused PR stack, so it is being closed. Any remaining provider/model configuration pieces can be resubmitted as a smaller dedicated PR.

@SivanCola SivanCola closed this Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant