Reject CThreshold parsing when k > 255#864
Draft
sethdusek wants to merge 3 commits into
Draft
Conversation
core2 was recently (unexpectedly) yanked. We only use it for IO traits so this isn't a big deal, we can just use no_std_io2
k was cast from u16 to u8 without a bounds check, so a value of k > 255 would be accepted with a truncated threshold (e.g. k=300 becomes k=44). Return a parsing error if k exceeds 255, matching sigmastate-interpreter's require(k <= children.length <= 255) check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
k was cast from u16 to u8 without a bounds check, so a wire value of
k > 255 would be silently accepted with a truncated threshold (e.g.
k=300 becomes k=44).
Return a parsing error if k exceeds 255, matching
sigmastate-interpreter's require(k <= children.length <= 255) check.
LLM disclosure: I used Claude to review the parsing implementations in Rust. It's found some interesting differences so far, this is one of them. I'm currently reviewing some of the other issues it has discovered.
Depends on #863 to get CI working