[Bug] Replace send_pickled in CARLA drivers#233
Conversation
6183218 to
42bbda9
Compare
|
Good catch, and thanks for the PR! It looks like storing pickled messages in these operators is redundant -- we can just stores messages directly. Could you update the PR to make that change? Concretely:
|
|
We we're doing this in order to move the pickling of large sensor messages from the critical the critical path. If we stop pre-pickling messages, and sending them using the |
|
Hmmm, maybe we need to re-introduce this function in ERDOS. I was under the impression that pickling a message took a negligible amount of time, but serializing a (1920, 1080, 3) numpy array takes around 15 ms on my laptop. |
|
Yes, I think it would be good to re-introduce this function for now in order to ensure that the driver operators do not affect our experiments. |
send_pickleis deprecated in erdos. These changes replace the functionality ofsend_pickleby unpickling the message then using the standardsendmethod. This is necessary for when running thepseudo-asynchronoussimulator mode.